repo
string
pull_number
int64
instance_id
string
issue_numbers
list
base_commit
string
patch
string
test_patch
string
problem_statement
string
hints_text
string
created_at
timestamp[ns, tz=UTC]
version
float64
eclipse-vertx/vert.x
1,907
eclipse-vertx__vert.x-1907
[ "1905" ]
c9bf0831c28d763ecf8717a588c56a6a3eebce07
diff --git a/src/main/java/io/vertx/core/eventbus/SendContext.java b/src/main/java/io/vertx/core/eventbus/SendContext.java --- a/src/main/java/io/vertx/core/eventbus/SendContext.java +++ b/src/main/java/io/vertx/core/eventbus/SendContext.java @@ -22,8 +22,12 @@ public interface SendContext<T> { void next(); /**...
diff --git a/src/test/java/io/vertx/test/core/EventBusTestBase.java b/src/test/java/io/vertx/test/core/EventBusTestBase.java --- a/src/test/java/io/vertx/test/core/EventBusTestBase.java +++ b/src/test/java/io/vertx/test/core/EventBusTestBase.java @@ -542,6 +542,28 @@ public void start(Future<Void> startFuture) throws E...
EventBus interceptor does not get message body when clustered From [David Klotz](https://groups.google.com/d/msg/vertx/7otR0fsI6_8/E4ZdC0usCQAJ) on the forum ``` Hi, I'm currently a bit confused by the differing behavior of event bus interceptors in a non-clustered and a clustered vert.x environment (currently ...
Reply from @tsegismont ``` Can you put together a small reproducer on GitHub ? Thanks ``` Reply from David Klotz ``` It's actually quite simple to reproduce, just run this with clustered = false or true (depends just on vertx and vertx-hazelcast) and observe the different output (just tried it with 3.4.1, stil...
2017-03-27T15:51:25Z
3.4
eclipse-vertx/vert.x
1,799
eclipse-vertx__vert.x-1799
[ "1765" ]
fb5ef766d36f692ed6bac4172ee5742dce1f97d8
diff --git a/src/main/java/io/vertx/core/eventbus/impl/clustered/ClusteredEventBus.java b/src/main/java/io/vertx/core/eventbus/impl/clustered/ClusteredEventBus.java --- a/src/main/java/io/vertx/core/eventbus/impl/clustered/ClusteredEventBus.java +++ b/src/main/java/io/vertx/core/eventbus/impl/clustered/ClusteredEventBu...
diff --git a/src/test/java/io/vertx/test/core/EventBusTestBase.java b/src/test/java/io/vertx/test/core/EventBusTestBase.java --- a/src/test/java/io/vertx/test/core/EventBusTestBase.java +++ b/src/test/java/io/vertx/test/core/EventBusTestBase.java @@ -19,9 +19,13 @@ import io.netty.util.CharsetUtil; import io.vertx.co...
NullPointer in sendToSubs Cloned from vert-x3/vertx-hazelcast#52
@inno-steffg _commented on 7 Dec 2016_ We're using vertx 3.3.3 in a productive environment clustered with hazelcast. We are observing the following NullPointerException from time to time: ``` 2016-12-07 09:57:08,063 ERROR [vert.x-eventloop-thread-4] [] io.vertx.core.impl.ContextImpl - Unhandled exception java.la...
2017-02-06T14:11:16Z
3.4
eclipse-vertx/vert.x
1,770
eclipse-vertx__vert.x-1770
[ "1769" ]
3db06e922eaedc18ff7027ed5a8a2d00adbf557f
diff --git a/src/main/java/io/vertx/core/file/impl/AsyncFileImpl.java b/src/main/java/io/vertx/core/file/impl/AsyncFileImpl.java --- a/src/main/java/io/vertx/core/file/impl/AsyncFileImpl.java +++ b/src/main/java/io/vertx/core/file/impl/AsyncFileImpl.java @@ -148,9 +148,10 @@ private synchronized AsyncFile doWrite(Buffe...
diff --git a/src/test/java/io/vertx/test/core/FileSystemTest.java b/src/test/java/io/vertx/test/core/FileSystemTest.java --- a/src/test/java/io/vertx/test/core/FileSystemTest.java +++ b/src/test/java/io/vertx/test/core/FileSystemTest.java @@ -54,6 +54,7 @@ import java.util.HashSet; import java.util.List; import java...
AsyncFile drain handler should not be called after the file is closed
2017-01-19T17:50:38Z
3.3
eclipse-vertx/vert.x
1,615
eclipse-vertx__vert.x-1615
[ "1613" ]
29c59aff1be0d8fd26b7d9bfd5619027fa5fc898
diff --git a/src/main/java/io/vertx/core/net/impl/KeyStoreHelper.java b/src/main/java/io/vertx/core/net/impl/KeyStoreHelper.java --- a/src/main/java/io/vertx/core/net/impl/KeyStoreHelper.java +++ b/src/main/java/io/vertx/core/net/impl/KeyStoreHelper.java @@ -236,7 +236,7 @@ public KeyStore loadStore(VertxInternal vertx...
diff --git a/src/test/java/io/vertx/test/core/ClusteredEventBusWithSSLTest.java b/src/test/java/io/vertx/test/core/ClusteredEventBusWithSSLTest.java --- a/src/test/java/io/vertx/test/core/ClusteredEventBusWithSSLTest.java +++ b/src/test/java/io/vertx/test/core/ClusteredEventBusWithSSLTest.java @@ -19,6 +19,8 @@ import...
Unable to load multiple client certificates into PEM trust store If I try to load multiple client certificates for client authentication, only one of the certificates gets loaded. ``` java PemTrustOptions trustStore = new PemTrustOptions(); File certDir = new File("cert"); File clientCertsDir = new Fil...
@eyce9000 can you make a test for this ?
2016-09-07T08:06:30Z
3.3
eclipse-vertx/vert.x
1,604
eclipse-vertx__vert.x-1604
[ "1602" ]
1adf3f020e91bf4525f5b5fe0120d5e04f5c1d14
diff --git a/src/main/java/io/vertx/core/net/impl/NetClientImpl.java b/src/main/java/io/vertx/core/net/impl/NetClientImpl.java --- a/src/main/java/io/vertx/core/net/impl/NetClientImpl.java +++ b/src/main/java/io/vertx/core/net/impl/NetClientImpl.java @@ -200,13 +200,13 @@ private void connect(int port, String host, Han...
diff --git a/src/test/java/io/vertx/test/core/NetTest.java b/src/test/java/io/vertx/test/core/NetTest.java --- a/src/test/java/io/vertx/test/core/NetTest.java +++ b/src/test/java/io/vertx/test/core/NetTest.java @@ -2299,11 +2299,6 @@ private TestLoggerFactory testLogging() throws Exception { */ @Test public v...
NetClient with SOCKS Proxy checks wrong hostname on upgradeToSsl() When using a NetClient with SOCKS Proxy, the upgradeToSsl() checks the ssl cert against the name of the proxy, not the name of the target server. I created a unit test that shows the issue by setting the proxy hostname to 127.0.0.1 and connecting to a ...
2016-09-03T13:04:57Z
3.3
eclipse-vertx/vert.x
1,565
eclipse-vertx__vert.x-1565
[ "1564" ]
07b7f47ae702d9d5f2f63228776ea00ea290e848
diff --git a/src/main/java/io/vertx/core/net/impl/SSLHelper.java b/src/main/java/io/vertx/core/net/impl/SSLHelper.java --- a/src/main/java/io/vertx/core/net/impl/SSLHelper.java +++ b/src/main/java/io/vertx/core/net/impl/SSLHelper.java @@ -33,7 +33,6 @@ import io.vertx.core.net.NetClientOptions; import io.vertx.core.n...
diff --git a/src/test/java/io/vertx/test/core/HttpTLSTest.java b/src/test/java/io/vertx/test/core/HttpTLSTest.java --- a/src/test/java/io/vertx/test/core/HttpTLSTest.java +++ b/src/test/java/io/vertx/test/core/HttpTLSTest.java @@ -276,7 +276,19 @@ public void testTLSVerifyNonMatchingHost() throws Exception { testT...
Remove KeyCertOptions limitation for OpenSSL The previous version of OpenSSL engine was restricted to use `pem` file format. Now the engine can use a generic `KeyManagerFactory` : https://github.com/netty/netty/pull/5439 We can so support it.
2016-08-05T14:10:13Z
3.3
eclipse-vertx/vert.x
1,476
eclipse-vertx__vert.x-1476
[ "1475" ]
1bbbc092ece499643d951defd4bd9a41c638b5f7
diff --git a/src/main/generated/io/vertx/core/dns/AddressResolverOptionsConverter.java b/src/main/generated/io/vertx/core/dns/AddressResolverOptionsConverter.java --- a/src/main/generated/io/vertx/core/dns/AddressResolverOptionsConverter.java +++ b/src/main/generated/io/vertx/core/dns/AddressResolverOptionsConverter.ja...
diff --git a/src/test/java/io/vertx/test/core/HostnameResolutionTest.java b/src/test/java/io/vertx/test/core/HostnameResolutionTest.java --- a/src/test/java/io/vertx/test/core/HostnameResolutionTest.java +++ b/src/test/java/io/vertx/test/core/HostnameResolutionTest.java @@ -35,6 +35,7 @@ import io.vertx.core.net.NetSe...
DNS search domains resolution Implements DNS search domains for the AddressResolver
2016-06-21T23:40:20Z
3.3
eclipse-vertx/vert.x
1,366
eclipse-vertx__vert.x-1366
[ "1345" ]
1ecfe11ae6a05bd56994e0e67c4273e66cf7537f
diff --git a/src/main/java/io/vertx/core/Starter.java b/src/main/java/io/vertx/core/Starter.java --- a/src/main/java/io/vertx/core/Starter.java +++ b/src/main/java/io/vertx/core/Starter.java @@ -477,14 +477,20 @@ private String readMainVerticleFromManifest() { try { Enumeration<URL> resources = getClass().g...
diff --git a/src/test/java/io/vertx/core/logging/SLF4JLogDelegateTest.java b/src/test/java/io/vertx/core/logging/SLF4JLogDelegateTest.java --- a/src/test/java/io/vertx/core/logging/SLF4JLogDelegateTest.java +++ b/src/test/java/io/vertx/core/logging/SLF4JLogDelegateTest.java @@ -29,6 +29,7 @@ import static junit.fram...
Nested zip tests fails on Windows ``` Failed tests: NestedZipFileResolverTest>AsyncTestBase.lambda$onSuccess$1:622->FileResolverTestBase.lambda$testCacheDirDeletedOnVertxClose$3:197->AsyncTestBase.assertFalse:208 null NestedZipFileResolverTest>AsyncTestBase.lambda$onSuccess$1:620->AsyncTestBase.fail:262 java.nio.fi...
same for nested jar: ``` Results : Failed tests: NestedJarFileResolverTest>AsyncTestBase.lambda$onSuccess$1:622->FileResolverTestBase.lambda$testCacheDirDeletedOnVertxClose$3:197->AsyncTestBase.assertFalse:208 null NestedJarFileResolverTest>AsyncTestBase.lambda$onSuccess$1:620->AsyncTestBase.fail:262 java.nio.fil...
2016-04-05T15:04:56Z
3.2
eclipse-vertx/vert.x
1,300
eclipse-vertx__vert.x-1300
[ "1298" ]
5b27163986f0fe344dc126acab030a307d842c38
diff --git a/src/main/java/io/vertx/core/impl/FileResolver.java b/src/main/java/io/vertx/core/impl/FileResolver.java --- a/src/main/java/io/vertx/core/impl/FileResolver.java +++ b/src/main/java/io/vertx/core/impl/FileResolver.java @@ -19,21 +19,21 @@ import io.vertx.core.*; import java.io.File; -import java.io.File...
diff --git a/src/test/java/io/vertx/test/core/NestedJarFileResolverTest.java b/src/test/java/io/vertx/test/core/NestedJarFileResolverTest.java --- a/src/test/java/io/vertx/test/core/NestedJarFileResolverTest.java +++ b/src/test/java/io/vertx/test/core/NestedJarFileResolverTest.java @@ -30,17 +30,17 @@ public class Nest...
FileResolver performance issue Fatjar it creates perf issues when unpacking resources because it went from ZipFile#entries() (that is basically a lookup in the Zip dir structure) to ZipFileInputStream that performs a scan of the Zip file. See this commit : https://github.com/eclipse/vert.x/commit/29000c63a56d5a9410498...
Reproducer : https://github.com/KlausSchaefers/vertx-static-slow2 Also need to add tests for nested jars because I don't see any.
2016-02-01T08:43:34Z
3.2
eclipse-vertx/vert.x
1,287
eclipse-vertx__vert.x-1287
[ "1286" ]
bb44eb6ff024a338da6824da7169a324cfc87954
diff --git a/src/main/java/io/vertx/core/json/JsonArray.java b/src/main/java/io/vertx/core/json/JsonArray.java --- a/src/main/java/io/vertx/core/json/JsonArray.java +++ b/src/main/java/io/vertx/core/json/JsonArray.java @@ -20,12 +20,7 @@ import io.vertx.core.shareddata.impl.ClusterSerializable; import java.time.Ins...
diff --git a/src/test/java/io/vertx/test/core/JsonArrayTest.java b/src/test/java/io/vertx/test/core/JsonArrayTest.java --- a/src/test/java/io/vertx/test/core/JsonArrayTest.java +++ b/src/test/java/io/vertx/test/core/JsonArrayTest.java @@ -1063,6 +1063,25 @@ public void testStreamCorrectTypes() throws Exception { t...
JsonArray.remove(int pos) should return JsonArray or JsonObject instead of their underlying implementations The current implementation returns / leaks a `java.util.ArrayList<?>` in case of a `JsonArray` or a Map in case of a `JsonObject`. It should check for these implementations and return a JsonArray or JsonObject wr...
2016-01-18T14:44:02Z
3.2
tailwindlabs/tailwindcss
17,647
tailwindlabs__tailwindcss-17647
[ "17643" ]
c0af1e2129828110fb4498f57b77d2e3bc1d3396
diff --git a/packages/tailwindcss/src/utilities.ts b/packages/tailwindcss/src/utilities.ts --- a/packages/tailwindcss/src/utilities.ts +++ b/packages/tailwindcss/src/utilities.ts @@ -4399,6 +4399,14 @@ export function createUtilities(theme: Theme) { { let value = resolveThemeColor(candidate, theme, ['--...
diff --git a/packages/tailwindcss/src/utilities.test.ts b/packages/tailwindcss/src/utilities.test.ts --- a/packages/tailwindcss/src/utilities.test.ts +++ b/packages/tailwindcss/src/utilities.test.ts @@ -20943,6 +20943,8 @@ test('filter', async () => { 'drop-shadow-[0_0_red]', 'drop-shadow-red-500', ...
`shadow-inherit` is broken **What version of Tailwind CSS are you using?** For example: v4.1.3 **What build tool (or framework if it abstracts the build tool) are you using?** Tailwind Play **What version of Node.js are you using?** Tailwind Play **What browser are you using?** Firefox and Chrome **What operati...
Seems like `inherit` is incompatible with the intensity modifiers of box shadows introduced in https://github.com/tailwindlabs/tailwindcss/pull/17398. I guess the `color-mix()` could be removed from the `inherit` value, or ~~to retain the intensity modifier, we move the intensity `color-mix()` into the `shadow-<size>` ...
2025-04-11T08:49:07Z
4.1
tailwindlabs/tailwindcss
17,754
tailwindlabs__tailwindcss-17754
[ "17295" ]
2bf2b4db98dd4e910d024d885416a2038f70d0d2
diff --git a/packages/@tailwindcss-postcss/src/index.ts b/packages/@tailwindcss-postcss/src/index.ts --- a/packages/@tailwindcss-postcss/src/index.ts +++ b/packages/@tailwindcss-postcss/src/index.ts @@ -103,6 +103,10 @@ function tailwindcss(opts: PluginOptions = {}): AcceptedPlugin { let context = getContext...
diff --git a/integrations/postcss/index.test.ts b/integrations/postcss/index.test.ts --- a/integrations/postcss/index.test.ts +++ b/integrations/postcss/index.test.ts @@ -635,3 +635,91 @@ test( await fs.expectFileToContain('project-a/dist/out.css', [candidate`content-['c/src/index.js']`]) }, ) + +test( + 'reb...
Angular 19 cannot automatically recover using @apply with Tailwind CSS 4 Tailwind CSS: 4.0.14 Angular: 19.2.4 Node: 23.6.0 Chrome: 134.0.6998.89 (Official Build) (arm64) MacOS: Sequoia 15.3.2 (24D81) **Reproduction URL** [https://github.com/micobarac/angular19](https://github.com/micobarac/angular19) **Describe your...
Same problem with Nuxt (vue js) What's worse, Angular team does not plan to fix this, stating: _Closing as there isn’t much we can do here. Tailwind is throwing an exception that causes the underlying PostCSS instance to crash and not return which files to watch._ I am guessing it is crashing here ... https://github.c...
2025-04-23T12:49:41Z
4.1
tailwindlabs/tailwindcss
17,301
tailwindlabs__tailwindcss-17301
[ "17288" ]
a1acaeeee0150a14c6b6843361805ffb961ad170
diff --git a/packages/tailwindcss/src/index.ts b/packages/tailwindcss/src/index.ts --- a/packages/tailwindcss/src/index.ts +++ b/packages/tailwindcss/src/index.ts @@ -696,6 +696,7 @@ export async function compileAst( } let didChange = defaultDidChange + let didAddExternalVariable = false def...
diff --git a/integrations/cli/index.test.ts b/integrations/cli/index.test.ts --- a/integrations/cli/index.test.ts +++ b/integrations/cli/index.test.ts @@ -1303,11 +1303,11 @@ test( `, ) - fs.expectFileToContain( + // prettier-ignore + await fs.expectFileToContain( './dist/out.css', ...
Changes in CSS file do not update Next.js setup <img width="701" alt="Image" src="https://github.com/user-attachments/assets/b7b9486e-7c1d-4412-8caf-b4bca1fe15a5" /> Section says that i can use CSS variables directly. It might be true in case of `static` theme, but it does not work for custom non-static theme which ge...
Hey there! This seems like a bug on our end, I agree that this should _just work_. We'll look into it. In the mean time, can you maybe share the contents of the file that references the CSS variable? I want to make sure we add a test case for your setup 👍 Also curious what extension you are using? Vite/CLI/PostCSS ...
2025-03-20T11:47:57Z
4
tailwindlabs/tailwindcss
16,800
tailwindlabs__tailwindcss-16800
[ "15467" ]
662c6862ac77f39498331ea2a0434d81f7e340c4
diff --git a/integrations/utils.ts b/integrations/utils.ts --- a/integrations/utils.ts +++ b/integrations/utils.ts @@ -42,7 +42,7 @@ interface TestContext { exec(command: string, options?: ChildProcessOptions, execOptions?: ExecOptions): Promise<string> spawn(command: string, options?: ChildProcessOptions): Promi...
diff --git a/integrations/cli/index.test.ts b/integrations/cli/index.test.ts --- a/integrations/cli/index.test.ts +++ b/integrations/cli/index.test.ts @@ -1314,3 +1314,79 @@ test( ) }, ) + +test( + 'can read files with UTF-8 files with BOM', + { + fs: { + 'package.json': json` + { + "...
Tailwindcss-cli silently fails when file is not UTF-8 **What version of Tailwind CSS are you using?** tailwindcss-cli v3.4.16 **What build tool (or framework if it abstracts the build tool) are you using?** tailwindcss-cli **What version of Node.js are you using?** none **What browser are you using?**...
2025-02-25T14:19:37Z
4
tailwindlabs/tailwindcss
16,631
tailwindlabs__tailwindcss-16631
[ "16358" ]
b9af722d13aadd271bef5ef9455b0725fdcb9d1c
diff --git a/packages/@tailwindcss-vite/src/index.ts b/packages/@tailwindcss-vite/src/index.ts --- a/packages/@tailwindcss-vite/src/index.ts +++ b/packages/@tailwindcss-vite/src/index.ts @@ -4,15 +4,13 @@ import { Scanner } from '@tailwindcss/oxide' import { Features as LightningCssFeatures, transform } from 'lightnin...
diff --git a/integrations/vite/astro.test.ts b/integrations/vite/astro.test.ts --- a/integrations/vite/astro.test.ts +++ b/integrations/vite/astro.test.ts @@ -1,4 +1,4 @@ -import { candidate, fetchStyles, html, json, retryAssertion, test, ts } from '../utils' +import { candidate, fetchStyles, html, js, json, retryAsser...
Vue static vdom stringifier breaks PostCSS in Nuxt Production build <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** v4.0.4 **What...
2025-02-18T13:38:06Z
4
tailwindlabs/tailwindcss
16,078
tailwindlabs__tailwindcss-16078
[ "16039" ]
88c890615a529cc8f7f253d75e25bd19bcf7e306
diff --git a/packages/@tailwindcss-node/src/urls.ts b/packages/@tailwindcss-node/src/urls.ts --- a/packages/@tailwindcss-node/src/urls.ts +++ b/packages/@tailwindcss-node/src/urls.ts @@ -149,9 +149,12 @@ async function doUrlReplace( return `${funcName}(${wrap}${newUrl}${wrap})` } -function skipUrlReplacer(rawUrl:...
diff --git a/packages/@tailwindcss-node/src/urls.test.ts b/packages/@tailwindcss-node/src/urls.test.ts --- a/packages/@tailwindcss-node/src/urls.test.ts +++ b/packages/@tailwindcss-node/src/urls.test.ts @@ -24,6 +24,20 @@ test('URLs can be rewritten', async () => { background: url('/image.jpg'); backg...
`@tailwindcss/vite` breaks `url()` using `resolve.alias` <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** 4.0.1 **What build tool ...
Same issue for me
2025-01-30T17:03:42Z
4
tailwindlabs/tailwindcss
16,103
tailwindlabs__tailwindcss-16103
[ "16100" ]
d85e9cfcab27f6e42a7e8a791979e072015790a3
diff --git a/packages/tailwindcss/src/compat/plugin-api.ts b/packages/tailwindcss/src/compat/plugin-api.ts --- a/packages/tailwindcss/src/compat/plugin-api.ts +++ b/packages/tailwindcss/src/compat/plugin-api.ts @@ -499,15 +499,18 @@ export function objectToAst(rules: CssInJs | CssInJs[]): AstNode[] { for (let [nam...
diff --git a/packages/tailwindcss/src/compat/plugin-api.test.ts b/packages/tailwindcss/src/compat/plugin-api.test.ts --- a/packages/tailwindcss/src/compat/plugin-api.test.ts +++ b/packages/tailwindcss/src/compat/plugin-api.test.ts @@ -1534,6 +1534,38 @@ describe('addBase', () => { " `) }) + + test('does...
CSS variables created by plugins are modified <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** v4.0.1 **What operating system are ...
Seems like it's coming from https://github.com/tailwindlabs/tailwindcss/blob/c09bb5e2562293c14248ad8fbad5bdb5b9b22058/packages/tailwindcss/src/compat/plugin-api.ts#L507. I can create a PR if this issue is labeled as a bug.
2025-01-31T09:20:27Z
4
tailwindlabs/tailwindcss
16,069
tailwindlabs__tailwindcss-16069
[ "16036" ]
deb33a93abbd94fd40fd2471f47df2e075a2107c
diff --git a/packages/@tailwindcss-vite/src/index.ts b/packages/@tailwindcss-vite/src/index.ts --- a/packages/@tailwindcss-vite/src/index.ts +++ b/packages/@tailwindcss-vite/src/index.ts @@ -8,6 +8,7 @@ import type { Plugin, ResolvedConfig, Rollup, Update, ViteDevServer } from 'vite const DEBUG = env.DEBUG const SP...
diff --git a/integrations/vite/html-style-blocks.test.ts b/integrations/vite/html-style-blocks.test.ts new file mode 100644 --- /dev/null +++ b/integrations/vite/html-style-blocks.test.ts @@ -0,0 +1,58 @@ +import { html, json, test, ts } from '../utils' + +test( + 'transforms html style blocks', + { + fs: { + ...
Cannot use HTML style tag with Vite to apply a theme <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** v4.0.1 **What build tool (or...
At best it would be if `<style type="text/tailwindcss">` is allowed in Vite, taken by tailwind and later replaced with `<style>` so other post processors can like minify the contents if not already.
2025-01-30T14:50:37Z
4
tailwindlabs/tailwindcss
15,576
tailwindlabs__tailwindcss-15576
[ "15562" ]
a3aec1790882223426a0705b99307c3e9342eaac
diff --git a/packages/@tailwindcss-cli/src/commands/build/index.ts b/packages/@tailwindcss-cli/src/commands/build/index.ts --- a/packages/@tailwindcss-cli/src/commands/build/index.ts +++ b/packages/@tailwindcss-cli/src/commands/build/index.ts @@ -445,7 +445,7 @@ function optimizeCss( deepSelectorCombinator: tr...
diff --git a/packages/@tailwindcss-postcss/src/__snapshots__/index.test.ts.snap b/packages/@tailwindcss-postcss/src/__snapshots__/index.test.ts.snap --- a/packages/@tailwindcss-postcss/src/__snapshots__/index.test.ts.snap +++ b/packages/@tailwindcss-postcss/src/__snapshots__/index.test.ts.snap @@ -400,9 +400,9 @@ expor...
Update lightningcss-win32-x64-msvc 1.26.0 → 1.28.2 (minor) Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ lightningcss-win32-x64-msvc (1.26.0 → 1.28.2) · [Repo](https://github.com/p...
Sorry, but the merge failed with: > At least 1 approving review is required by reviewers with write access.
2025-01-09T09:47:12Z
4
tailwindlabs/tailwindcss
15,318
tailwindlabs__tailwindcss-15318
[ "15315" ]
94a3cff6874526a75c1221f4b951c9f5b009cd91
diff --git a/packages/tailwindcss/src/compat/flatten-color-palette.ts b/packages/tailwindcss/src/compat/flatten-color-palette.ts --- a/packages/tailwindcss/src/compat/flatten-color-palette.ts +++ b/packages/tailwindcss/src/compat/flatten-color-palette.ts @@ -4,7 +4,7 @@ type Colors = { [key: string | number]: string...
diff --git a/packages/tailwindcss/src/compat/config.test.ts b/packages/tailwindcss/src/compat/config.test.ts --- a/packages/tailwindcss/src/compat/config.test.ts +++ b/packages/tailwindcss/src/compat/config.test.ts @@ -1,7 +1,7 @@ import { describe, expect, test, vi } from 'vitest' import { compile, type Config } fro...
Trying to upgrade a plugin to v4 <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** v4 **What build tool (or framework if it a...
2024-12-06T10:40:19Z
4
tailwindlabs/tailwindcss
15,183
tailwindlabs__tailwindcss-15183
[ "15170" ]
124b82bc7999391f2f551b440f1e0241bcd01af6
diff --git a/packages/tailwindcss/src/utilities.ts b/packages/tailwindcss/src/utilities.ts --- a/packages/tailwindcss/src/utilities.ts +++ b/packages/tailwindcss/src/utilities.ts @@ -651,6 +651,11 @@ export function createUtilities(theme: Theme) { */ staticUtility('col-auto', [['grid-column', 'auto']]) functi...
diff --git a/packages/tailwindcss/src/utilities.test.ts b/packages/tailwindcss/src/utilities.test.ts --- a/packages/tailwindcss/src/utilities.test.ts +++ b/packages/tailwindcss/src/utilities.test.ts @@ -1086,6 +1086,8 @@ test('order', async () => { test('col', async () => { expect( await run([ + 'col-11',...
[v4] arbritary values for row and col classes In v4 utilities some utilities like grid-cols-12 and z-40 do not depend on the theme values and just work. Does that mean that row-42 should also just work? Because it does not work in v4.0.0-beta.2. I still need the square brackets like row-[42].
Hey! I think you're looking for `row-start-42` which will work. `row-[42]` didn't work in v3 and is a new class in v4 for the shorthand `grid-row` property where I think it's most common to pass multiple values like `grid-row: 3 / 6` but it does work with one value too so maybe we can make that work anyways also. I thi...
2024-11-25T22:59:47Z
4
tailwindlabs/tailwindcss
15,003
tailwindlabs__tailwindcss-15003
[ "15000" ]
4de07697bdd7cb99eb4557456a31338c53f45ccc
diff --git a/src/util/removeAlphaVariables.js b/src/util/removeAlphaVariables.js --- a/src/util/removeAlphaVariables.js +++ b/src/util/removeAlphaVariables.js @@ -18,6 +18,8 @@ export function removeAlphaVariables(container, toRemove) { for (let varName of toRemove) { if (decl.value.includes(`/ var(${varNam...
diff --git a/integrations/parcel/tests/integration.test.js b/integrations/parcel/tests/integration.test.js --- a/integrations/parcel/tests/integration.test.js +++ b/integrations/parcel/tests/integration.test.js @@ -74,7 +74,7 @@ describe('static build', () => { expect(await readOutputFile(/index\.\w+\.css$/)).toIn...
Selection is broken in Chrome 131 due to --tw-text-opacity and friends **What version of Tailwind CSS are you using?** Not sure what version sites are using, but I suspect less than a year old. **What build tool (or framework if it abstracts the build tool) are you using?** Don't know **What version of Node...
2024-11-14T17:28:54Z
3.4
tailwindlabs/tailwindcss
14,962
tailwindlabs__tailwindcss-14962
[ "14960" ]
50d7355f7f81939172af1161e0930dc381d599ca
diff --git a/packages/tailwindcss/src/utilities.ts b/packages/tailwindcss/src/utilities.ts --- a/packages/tailwindcss/src/utilities.ts +++ b/packages/tailwindcss/src/utilities.ts @@ -387,6 +387,8 @@ export function createUtilities(theme: Theme) { handleNegativeBareValue: ({ value }) => { let multiplier ...
diff --git a/packages/tailwindcss/src/utilities.test.ts b/packages/tailwindcss/src/utilities.test.ts --- a/packages/tailwindcss/src/utilities.test.ts +++ b/packages/tailwindcss/src/utilities.test.ts @@ -3861,6 +3861,82 @@ test('translate-x', async () => { '-translate-x-[var(--value)]/foo', ]), ).toEqual(...
v4 alpha.32 translate regression <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** v4 alpha 32 **What build tool (or framewor...
@madmoizo Thanks for the report! I can reproduce this issue as well. Looking into it!
2024-11-11T18:09:40Z
4
tailwindlabs/tailwindcss
14,981
tailwindlabs__tailwindcss-14981
[ "14965" ]
0b908f3992d83ded583bf59f2457c41670418eca
diff --git a/integrations/utils.ts b/integrations/utils.ts --- a/integrations/utils.ts +++ b/integrations/utils.ts @@ -46,7 +46,7 @@ interface TestContext { dumpFiles(pattern: string): Promise<string> expectFileToContain( filePath: string, - contents: string | string[] | RegExp | RegExp[], + ...
diff --git a/integrations/vite/svelte.test.ts b/integrations/vite/svelte.test.ts --- a/integrations/vite/svelte.test.ts +++ b/integrations/vite/svelte.test.ts @@ -48,22 +48,50 @@ test( target: document.body, }) `, + 'src/index.css': css` + @import 'tailwindcss/theme' theme(referen...
[v4] Vite plugin breaks svelte global animation keyframes handling **What version of Tailwind CSS are you using?** v4.0.0-alpha.32 **What build tool (or framework if it abstracts the build tool) are you using?** Vite with SvelteKit 2.8.0 (latest) **What version of Node.js are you using?** For example: v2...
Yeah it does seem that the default Svelte transforms now no longer apply at all. Looking into it, thanks for the report.
2024-11-12T17:28:56Z
4
tailwindlabs/tailwindcss
14,993
tailwindlabs__tailwindcss-14993
[ "13129" ]
dda181b833c472bf4070f6c0c1d61fb88c016368
diff --git a/packages/tailwindcss/src/property-order.ts b/packages/tailwindcss/src/property-order.ts --- a/packages/tailwindcss/src/property-order.ts +++ b/packages/tailwindcss/src/property-order.ts @@ -28,6 +28,10 @@ export default [ 'float', 'clear', + // Ensure that the included `container` class is always ...
diff --git a/packages/tailwindcss/src/__snapshots__/intellisense.test.ts.snap b/packages/tailwindcss/src/__snapshots__/intellisense.test.ts.snap --- a/packages/tailwindcss/src/__snapshots__/intellisense.test.ts.snap +++ b/packages/tailwindcss/src/__snapshots__/intellisense.test.ts.snap @@ -3375,6 +3375,7 @@ exports[`ge...
[v4] Styles are not applied to the "container" class **What version of Tailwind CSS are you using?** v.next **What build tool (or framework if it abstracts the build tool) are you using?** vite (v5.1.5), @builder.io/qwik (v1.5.1), @builder.io/qwik-city (v1.5.1), @tailwindcss/vite (v.next) **What version of Node...
I am using SvelteKit and I can comfirm this. Using Vite with nuxt with same problem I guess it is not implemented yet, I don't see it in the [packages/tailwindcss/src/utilities.ts](https://github.com/tailwindlabs/tailwindcss/blob/next/packages/tailwindcss/src/utilities.ts). @adamwathan Has any decision been made re...
2024-11-13T16:49:01Z
4
tailwindlabs/tailwindcss
14,744
tailwindlabs__tailwindcss-14744
[ "14726" ]
18cb3c60e6e83a7d1aad120f8552d8805a241779
diff --git a/packages/@tailwindcss-cli/src/commands/build/index.ts b/packages/@tailwindcss-cli/src/commands/build/index.ts --- a/packages/@tailwindcss-cli/src/commands/build/index.ts +++ b/packages/@tailwindcss-cli/src/commands/build/index.ts @@ -122,11 +122,12 @@ export async function handle(args: Result<ReturnType<ty...
diff --git a/integrations/cli/index.test.ts b/integrations/cli/index.test.ts --- a/integrations/cli/index.test.ts +++ b/integrations/cli/index.test.ts @@ -210,6 +210,23 @@ describe.each([ } `, ]) + + await fs.write( + 'project-a/src/index.css', + css` + @import 'ta...
V4 Alpha 27/28 - `--watch` command does not work on the input css file (config file) **What version of Tailwind CSS are you using?** v4.0.0.alpha28 (also tried on alpha27) **What build tool (or framework if it abstracts the build tool) are you using?** Tailwind CLI executable only. **What version of Node.js...
I've updated the title to also include the regular CLI which also doesn't support --watch. I went back to [the article announcing v4](https://tailwindcss.com/blog/tailwindcss-v4-alpha) and realised it doesn't mention the `--watch` flag. Is there a reason for it? Is watch mode not supported just yet? I can't seem to ...
2024-10-21T20:17:01Z
4
tailwindlabs/tailwindcss
14,747
tailwindlabs__tailwindcss-14747
[ "14732" ]
338a78050a78ee1d3f0f12824d9fb04614c93700
diff --git a/packages/tailwindcss/src/compat/plugin-api.ts b/packages/tailwindcss/src/compat/plugin-api.ts --- a/packages/tailwindcss/src/compat/plugin-api.ts +++ b/packages/tailwindcss/src/compat/plugin-api.ts @@ -204,7 +204,7 @@ export function buildPluginApi( for (let [name, css] of Object.entries(utils)) {...
diff --git a/integrations/cli/plugins.test.ts b/integrations/cli/plugins.test.ts --- a/integrations/cli/plugins.test.ts +++ b/integrations/cli/plugins.test.ts @@ -154,6 +154,7 @@ test( candidate`duration-350`, 'transition-duration: 350ms', 'animation-duration: 350ms', + '@keyframes enter {', ...
v4 alpha 0.28 breaks plugin (tailwindcss-animate) & weird behavior with new p3 color opacity <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are y...
Dropping some notes for me to look at tomorrow: Regarding the colors: - This is only an issue in Chrome, FF and Safari are fine - The trigger requires an oklch/okblab color with a `none` component. Replacing it with a `0` fixes the issue. - Changing the color space of the color-mix _also_ fixes the issue (but sho...
2024-10-21T22:17:16Z
4
tailwindlabs/tailwindcss
14,877
tailwindlabs__tailwindcss-14877
[ "14784" ]
75eeed85b6cafe9b7b406a0df0fdfcbf2425360a
diff --git a/integrations/utils.ts b/integrations/utils.ts --- a/integrations/utils.ts +++ b/integrations/utils.ts @@ -29,7 +29,7 @@ interface ExecOptions { interface TestConfig { fs: { - [filePath: string]: string + [filePath: string]: string | Uint8Array } } interface TestContext { @@ -280,8 +280,14 ...
diff --git a/integrations/vite/url-rewriting.test.ts b/integrations/vite/url-rewriting.test.ts new file mode 100644 --- /dev/null +++ b/integrations/vite/url-rewriting.test.ts @@ -0,0 +1,97 @@ +import { describe, expect } from 'vitest' +import { binary, css, html, svg, test, ts, txt } from '../utils' + +const SIMPLE_IM...
[4 alpha] breaks the default Vite `url(...)` references in imported CSS files. **What version of Tailwind CSS are you using?** For example: alpha.29 (latest) **What build tool (or framework if it abstracts the build tool) are you using?** For example: Vite 5.4.10 (latest) **What version of Node.js are you u...
@slavarazum Thanks for the report! We'll look into it. You can work around this for now by using the `@tailwindcss/postcss` client rather than the Vite client which should preserve the existing logic. Wow, Tailwind team are really quick nowdays :) Thanx for the suggestion, have already temporary migrated.
2024-11-05T15:33:38Z
4
tailwindlabs/tailwindcss
14,269
tailwindlabs__tailwindcss-14269
[ "14106" ]
a1d56d8e24574eeb748c3045c1cb32874120b981
diff --git a/integrations/utils.ts b/integrations/utils.ts --- a/integrations/utils.ts +++ b/integrations/utils.ts @@ -1,7 +1,7 @@ import dedent from 'dedent' import fastGlob from 'fast-glob' import killPort from 'kill-port' -import { execSync, spawn } from 'node:child_process' +import { exec, spawn } from 'node:chi...
diff --git a/integrations/vite/index.test.ts b/integrations/vite/index.test.ts --- a/integrations/vite/index.test.ts +++ b/integrations/vite/index.test.ts @@ -1,5 +1,5 @@ import path from 'node:path' -import { expect } from 'vitest' +import { describe, expect } from 'vitest' import { candidate, css, @@ -12,93 +...
[v4] vite build --watch only compile html classes right on the init run **What version of Tailwind CSS are you using?** v4 **What build tool (or framework if it abstracts the build tool) are you using?** Plain vite Projekt with css/html Input files in rollup config **What version of Node.js are you using?** v20....
try adding purge: ["./src/**/*.{html,js}"], in the tailwind config file @Massa-Albani4 Its the vite Plugin from v4 no tailwindcss config anymore @KartoffelToby Heya! Do you have a repro that you can share? We've been looking into the Vite plugin just last week and as a result of that also added a new integration test t...
2024-08-27T10:21:12Z
3.4
tailwindlabs/tailwindcss
13,949
tailwindlabs__tailwindcss-13949
[ "13948" ]
62de02a37946c48c5fa6cdb800173b54198ebb9b
diff --git a/packages/tailwindcss/playwright.config.ts b/packages/tailwindcss/playwright.config.ts --- a/packages/tailwindcss/playwright.config.ts +++ b/packages/tailwindcss/playwright.config.ts @@ -36,11 +36,14 @@ export default defineConfig({ name: 'chromium', use: { ...devices['Desktop Chrome'] }, ...
diff --git a/packages/tailwindcss/src/__snapshots__/index.test.ts.snap b/packages/tailwindcss/src/__snapshots__/index.test.ts.snap --- a/packages/tailwindcss/src/__snapshots__/index.test.ts.snap +++ b/packages/tailwindcss/src/__snapshots__/index.test.ts.snap @@ -431,11 +431,11 @@ exports[`compiling CSS > \`@tailwind ut...
Gradients do not work in Firefox in v4.0.0-alpha.16, potentially caused by special `@supports (-moz-orient: inline)` selector ### Discussed in https://github.com/tailwindlabs/tailwindcss/discussions/13941 , since it is reproducible in tailwind play, I think it is indeed a bug and created the issue for it. **What ver...
2024-07-04T14:12:50Z
3.4
tailwindlabs/tailwindcss
13,770
tailwindlabs__tailwindcss-13770
[ "13769" ]
9fda4616eb5706223374c921c9ee4d90903f6fee
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -434,23 +434,40 @@ export let variantPlugins = { ) }, - hasVariants: ({ matchVariant }) => { - matchVariant('has', (value) => `&:has(${normalize(value)})`, { values: {} }) + hasVariants: ({ matchVari...
diff --git a/tests/prefix.test.js b/tests/prefix.test.js --- a/tests/prefix.test.js +++ b/tests/prefix.test.js @@ -637,3 +637,132 @@ test('does not prefix arbitrary group/peer classes', async () => { } `) }) + +test('does not prefix has-* variants with arbitrary values', async () => { + let config = { + pr...
Classes are prefixed when using `has-*` variants with arbitrary values **What version of Tailwind CSS are you using?** v3.4.3 **What build tool (or framework if it abstracts the build tool) are you using?** Tested using `play.tailwindcss.com` and added some test to `tailwindcss` repo. **What version of Node...
2024-05-31T06:59:16Z
3.4
tailwindlabs/tailwindcss
13,379
tailwindlabs__tailwindcss-13379
[ "13037" ]
97607f1cfb30103db96747c9b9e50fefa117fbb4
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -270,7 +270,7 @@ export let variantPlugins = { addVariant('dark', selector) } else if (mode === 'class') { // Old behavior - addVariant('dark', `:is(${selector} &)`) + addVariant('dark'...
diff --git a/tests/apply.test.js b/tests/apply.test.js --- a/tests/apply.test.js +++ b/tests/apply.test.js @@ -2212,3 +2212,40 @@ test('applying user defined classes with nested CSS should result in an error', `) }) }) + +test('applying classes with class-based dark variant to pseudo elements', async () => { +...
dark selector does not work correctly in @apply starting from version 3.3.0 <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?**: v3.3...
Definitely a real bug, thanks for reporting! My gut is we can fix this by updating the `class` strategy implementation to work like the `selector` strategy implementation, where we put the `&` at the front: ```diff } else if (mode === 'class') { - addVariant('dark', `:is(${selector} &)`) + addVariant('dark'...
2024-03-27T14:14:41Z
3.4
tailwindlabs/tailwindcss
11,470
tailwindlabs__tailwindcss-11470
[ "11466" ]
eae2b7a3f4f3a2981614a580a9f5534b9ffe0586
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -933,7 +933,7 @@ export let corePlugins = { }, animation: ({ matchUtilities, theme, config }) => { - let prefixName = (name) => `${config('prefix')}${escapeClassName(name)}` + let prefixName = (name) ...
diff --git a/tests/animations.test.js b/tests/animations.test.js --- a/tests/animations.test.js +++ b/tests/animations.test.js @@ -277,3 +277,33 @@ test('with dots in the name and prefix', () => { `) }) }) + +test('special character prefixes are escaped in animation names', () => { + let config = { + prefi...
Animation Names Won't Be Escaped If Prefix Contains Especial Characters **What version of Tailwind CSS are you using?** v3.3.2 **What build tool (or framework if it abstracts the build tool) are you using?** Tailwind Play **What version of Node.js are you using?** N/A **What browser are you using?** ...
2023-06-21T14:08:19Z
3.3
tailwindlabs/tailwindcss
12,404
tailwindlabs__tailwindcss-12404
[ "12401" ]
a5a61580cdb6974207a77680b70ba3906b31515b
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -1129,6 +1129,7 @@ export let corePlugins = { appearance: ({ addUtilities }) => { addUtilities({ '.appearance-none': { appearance: 'none' }, + '.appearance-auto': { appearance: 'auto' }, })...
diff --git a/tests/plugins/__snapshots__/appearance.test.js.snap b/tests/plugins/__snapshots__/appearance.test.js.snap --- a/tests/plugins/__snapshots__/appearance.test.js.snap +++ b/tests/plugins/__snapshots__/appearance.test.js.snap @@ -6,5 +6,10 @@ exports[`should test the 'appearance' plugin 1`] = ` -webkit-appe...
Missing `appearance-none` <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** 3.3.5 **What build tool (or framework if it abstr...
2023-11-12T16:08:50Z
3.3
tailwindlabs/tailwindcss
11,157
tailwindlabs__tailwindcss-11157
[ "11027" ]
cdca9cbcfe331b54ca4df80bc720f8cd78e303a0
diff --git a/src/lib/evaluateTailwindFunctions.js b/src/lib/evaluateTailwindFunctions.js --- a/src/lib/evaluateTailwindFunctions.js +++ b/src/lib/evaluateTailwindFunctions.js @@ -1,7 +1,7 @@ import dlv from 'dlv' import didYouMean from 'didyoumean' import transformThemeValue from '../util/transformThemeValue' -impor...
diff --git a/tests/evaluateTailwindFunctions.test.js b/tests/evaluateTailwindFunctions.test.js --- a/tests/evaluateTailwindFunctions.test.js +++ b/tests/evaluateTailwindFunctions.test.js @@ -1383,5 +1383,36 @@ crosscheck(({ stable, oxide }) => { // 4. But we've not received any further logs about it expec...
Incorrect parsing of theme functions within calc operations without spaces <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** v3....
2023-05-04T13:50:14Z
3.3
tailwindlabs/tailwindcss
12,113
tailwindlabs__tailwindcss-12113
[ "12111" ]
457d2b1b1c5dc09b2edbc92f1dd1499a00cd4ef0
diff --git a/src/lib/generateRules.js b/src/lib/generateRules.js --- a/src/lib/generateRules.js +++ b/src/lib/generateRules.js @@ -815,10 +815,19 @@ function applyFinalFormat(match, { context, candidate }) { } try { - rule.selector = finalizeSelector(rule.selector, finalFormat, { + let selector = ...
diff --git a/tests/basic-usage.test.js b/tests/basic-usage.test.js --- a/tests/basic-usage.test.js +++ b/tests/basic-usage.test.js @@ -792,3 +792,46 @@ test('Skips classes inside :not() when nested inside an at-rule', async () => { expect(result.css).toMatchFormattedCss(css``) }) + +test('Irrelevant rules are rem...
Combination of TW JS based config and a class causes malformed CSS **What version of Tailwind CSS are you using?** v3.3.3 **What build tool (or framework if it abstracts the build tool) are you using?** Vite v4.4.9 **What version of Node.js are you using?** v20.7.0 **What browser are you using?** A...
2023-09-29T20:14:25Z
3.3
tailwindlabs/tailwindcss
11,002
tailwindlabs__tailwindcss-11002
[ "10989" ]
e3a9d5f53bd9f8aadb0bee7ed9c20ea69bb8fcc3
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -1750,7 +1750,13 @@ export let corePlugins = { return withAlphaValue(value, 0, 'rgb(255 255 255 / 0)') } - return function ({ matchUtilities, theme }) { + return function ({ matchUtilities, them...
diff --git a/tests/any-type.test.js b/tests/any-type.test.js --- a/tests/any-type.test.js +++ b/tests/any-type.test.js @@ -500,21 +500,16 @@ crosscheck(({ stable, oxide }) => { } .from-\[var\(--any-value\)\] { --tw-gradient-from: var(--any-value) var(--tw-gradient-from-position); - ...
Unexpected gradient-stop behavior across light and dark modes <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** `v3.3.1` **Wh...
2023-04-13T15:50:48Z
3.3
tailwindlabs/tailwindcss
10,288
tailwindlabs__tailwindcss-10288
[ "10267" ]
b05918ab75370bfbecb3d556fec8846cbd285f0d
diff --git a/src/lib/offsets.js b/src/lib/offsets.js --- a/src/lib/offsets.js +++ b/src/lib/offsets.js @@ -13,6 +13,7 @@ import { remapBitfield } from './remap-bitfield.js' * @property {function | undefined} sort The sort function * @property {string|null} value The value we want to compare * @property {string|nu...
diff --git a/tests/arbitrary-variants.test.js b/tests/arbitrary-variants.test.js --- a/tests/arbitrary-variants.test.js +++ b/tests/arbitrary-variants.test.js @@ -1158,3 +1158,201 @@ it('Invalid arbitrary variants selectors should produce nothing instead of faili expect(result.css).toMatchFormattedCss(css``) })...
Order of CSS selectors is not correct with v3.2.x in specific scenarios **What version of Tailwind CSS are you using?** v3.2.4 **What build tool (or framework if it abstracts the build tool) are you using?** I use Vite. But I was able to reproduce the bug with `npx tailwindcss -i ./src/style.css -o ./dist/styl...
Thanks for reporting, I was able to distill the reproduction down to this minimal demo on Tailwind Play: https://play.tailwindcss.com/3ujiz5LanM Can see the sorting issue in the "Generated CSS" tab. Will look at this one next week! Thanks for the reporting...
2023-01-10T14:50:56Z
3.2
tailwindlabs/tailwindcss
10,074
tailwindlabs__tailwindcss-10074
[ "9832" ]
25d17db78c7c04c0314f8597138dc4564fc07c16
diff --git a/src/util/dataTypes.js b/src/util/dataTypes.js --- a/src/util/dataTypes.js +++ b/src/util/dataTypes.js @@ -10,6 +10,9 @@ function isCSSFunction(value) { return cssFunctions.some((fn) => new RegExp(`^${fn}\\(.*\\)`).test(value)) } +const placeholder = '--tw-placeholder' +const placeholderRe = new RegEx...
diff --git a/tests/arbitrary-values.test.css b/tests/arbitrary-values.test.css --- a/tests/arbitrary-values.test.css +++ b/tests/arbitrary-values.test.css @@ -191,6 +191,15 @@ .w-\[\'\}\{\}\'\] { width: '}{}'; } +.min-w-\[calc\(1-var\(--something\)\*0\.5\)\] { + min-width: calc(1 - var(--something) * 0.5); +} +.m...
Subtraction in `calc()` arbitrary values not always normalized properly <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** v3.2.4...
The only place you can use the calc() function is in values. See these examples where we’re setting the value for a number of different properties. .el { font-size: calc(3vw + 2px); width: calc(100% - 20px); height: calc(100vh - 20px); padding: calc(1vw + 5px); }
2022-12-14T11:48:57Z
3.2
tailwindlabs/tailwindcss
10,601
tailwindlabs__tailwindcss-10601
[ "10582" ]
66c640b73599e36c6087644d3b2c231cc17b37ff
diff --git a/src/lib/generateRules.js b/src/lib/generateRules.js --- a/src/lib/generateRules.js +++ b/src/lib/generateRules.js @@ -3,10 +3,14 @@ import selectorParser from 'postcss-selector-parser' import parseObjectStyles from '../util/parseObjectStyles' import isPlainObject from '../util/isPlainObject' import pref...
diff --git a/tests/important-modifier.test.js b/tests/important-modifier.test.js --- a/tests/important-modifier.test.js +++ b/tests/important-modifier.test.js @@ -108,4 +108,46 @@ crosscheck(() => { `) }) }) + + test('the important modifier works on utilities using :where()', () => { + let config = {...
Using `:where(.anything)` in a plugin and having `!anything` inside HTML, creates invalid CSS <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are ...
Thanks for reporting! Here's a slightly simplified reproduction for our own reference: https://play.tailwindcss.com/4MqOxcleAv?file=config
2023-02-16T14:48:07Z
3.2
tailwindlabs/tailwindcss
9,704
tailwindlabs__tailwindcss-9704
[ "9677" ]
c9369894d6484ff2b95a987fb1f63595d5fb1891
diff --git a/src/lib/generateRules.js b/src/lib/generateRules.js --- a/src/lib/generateRules.js +++ b/src/lib/generateRules.js @@ -3,7 +3,7 @@ import selectorParser from 'postcss-selector-parser' import parseObjectStyles from '../util/parseObjectStyles' import isPlainObject from '../util/isPlainObject' import prefix...
diff --git a/tests/important-modifier.test.js b/tests/important-modifier.test.js --- a/tests/important-modifier.test.js +++ b/tests/important-modifier.test.js @@ -13,12 +13,13 @@ test('important modifier', () => { <div class="lg:!opacity-50"></div> <div class="xl:focus:disabled:!float-right"></div...
Unexpected !important added when rules have multiple selectors <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** v3.2.1 **Wha...
2022-11-01T12:39:13Z
3.2
tailwindlabs/tailwindcss
9,405
tailwindlabs__tailwindcss-9405
[ "6517" ]
bf4494104953b13a5f326b250d7028074815e77e
diff --git a/src/cli.js b/src/cli.js --- a/src/cli.js +++ b/src/cli.js @@ -1,29 +1,12 @@ #!/usr/bin/env node -import { lazyPostcss, lazyPostcssImport, lazyCssnano, lazyAutoprefixer } from '../peers/index.js' - -import chokidar from 'chokidar' import path from 'path' import arg from 'arg' import fs from 'fs' -impo...
diff --git a/integrations/tailwindcss-cli/tests/integration.test.js b/integrations/tailwindcss-cli/tests/integration.test.js --- a/integrations/tailwindcss-cli/tests/integration.test.js +++ b/integrations/tailwindcss-cli/tests/integration.test.js @@ -1,3 +1,4 @@ +let fs = require('fs') let $ = require('../../execute')...
Resolve config file relative to the file being transformed instead of cwd **What version of Tailwind CSS are you using?** v3.0.2 **What build tool (or framework if it abstracts the build tool) are you using?** Parcel 2 👋 **What version of Node.js are you using?** 16 **What operating system are you u...
2022-09-23T17:12:38Z
3.1
tailwindlabs/tailwindcss
9,319
tailwindlabs__tailwindcss-9319
[ "9318" ]
527031d5f679a958a7d0de045a057a1e32db2985
diff --git a/src/lib/evaluateTailwindFunctions.js b/src/lib/evaluateTailwindFunctions.js --- a/src/lib/evaluateTailwindFunctions.js +++ b/src/lib/evaluateTailwindFunctions.js @@ -7,6 +7,7 @@ import buildMediaQuery from '../util/buildMediaQuery' import { toPath } from '../util/toPath' import { withAlphaValue } from '....
diff --git a/tests/evaluateTailwindFunctions.test.js b/tests/evaluateTailwindFunctions.test.js --- a/tests/evaluateTailwindFunctions.test.js +++ b/tests/evaluateTailwindFunctions.test.js @@ -1,14 +1,18 @@ +import fs from 'fs' +import path from 'path' import postcss from 'postcss' import plugin from '../src/lib/evalua...
Tailwind compiler crashes when you try to `[--box-shadow:theme('boxShadow.doesNotExist')]` **What version of Tailwind CSS are you using?** v3.1.8 **What build tool (or framework if it abstracts the build tool) are you using?** vite 3.0.9, postcss 8.4.14 postcss-cli 8.3.1 **What version of Node.js are you us...
2022-09-13T18:05:38Z
3.1
tailwindlabs/tailwindcss
9,208
tailwindlabs__tailwindcss-9208
[ "9205" ]
da850424dcdf011acda795b52c87cbd28628c943
diff --git a/src/lib/expandTailwindAtRules.js b/src/lib/expandTailwindAtRules.js --- a/src/lib/expandTailwindAtRules.js +++ b/src/lib/expandTailwindAtRules.js @@ -177,16 +177,12 @@ export default function expandTailwindAtRules(context) { let classCacheCount = context.classCache.size env.DEBUG && console.tim...
diff --git a/tests/important-boolean.test.js b/tests/important-boolean.test.js --- a/tests/important-boolean.test.js +++ b/tests/important-boolean.test.js @@ -1,7 +1,8 @@ import fs from 'fs' import path from 'path' +import * as sharedState from '../src/lib/sharedState' -import { run, css } from './util/run' +import...
Using important: true leads to duplicate rules in output This issue supersedes #9203 which was a bit of a false start. V3.1.18 Tailwind CLI Node v14.18.1 Chrome Window 10 (No Docker or WSL) Command line : npx tailwindcss --output twout.css --watch -i twbase.css Reproduction URL: https://github.com/willdean/Tw...
In case this raises questions about PostCSS: ``` >npm -g list postcss C:\Users\will\AppData\Roaming\npm `-- tailwindcss@3.1.8 +-- postcss-import@14.1.0 | `-- postcss@8.4.16 deduped +-- postcss-js@4.0.0 | `-- postcss@8.4.16 deduped +-- postcss-load-config@3.1.4 | `-- postcss@8.4.16 deduped +-- p...
2022-08-29T17:47:47Z
3.1
tailwindlabs/tailwindcss
8,773
tailwindlabs__tailwindcss-8773
[ "8626" ]
5191ec1c006dfd6ac911e53d30f12993fe4eb586
diff --git a/src/lib/generateRules.js b/src/lib/generateRules.js --- a/src/lib/generateRules.js +++ b/src/lib/generateRules.js @@ -129,6 +129,7 @@ function applyVariant(variant, matches, context) { } let args + let isArbitraryVariant = false // Find partial arbitrary variants if (variant.endsWith(']') ...
diff --git a/tests/arbitrary-variants.test.js b/tests/arbitrary-variants.test.js --- a/tests/arbitrary-variants.test.js +++ b/tests/arbitrary-variants.test.js @@ -527,3 +527,42 @@ test('allows attribute variants with quotes', () => { `) }) }) + +test('classes in arbitrary variants should not be prefixed', () =...
Classes inside arbitrary variants are incorrectly being prefixed Classes inside arbitrary variants are prefixed when they shouldn't be as they're not tailwind utilities. The utility `[.foo_&]:tw-text-red-400` incorrectly generates a selector referencing `.tw-foo` instead of `.foo` See: https://github.com/tailwind...
I put \ in front of '.foo_&' and it is some how giving selector .foo https://play.tailwindcss.com/LWujxXokrG @thecrypticace I built upon your example and created an example to test classes, IDs, and attributes. It appears IDs work as expected, but both classes and attributes experience bugs when using prefixes, ...
2022-07-04T18:43:56Z
3.1
tailwindlabs/tailwindcss
8,687
tailwindlabs__tailwindcss-8687
[ "8660" ]
77c248cabb38d085df9ce9ca32e4f865f07bcd27
diff --git a/src/lib/defaultExtractor.js b/src/lib/defaultExtractor.js --- a/src/lib/defaultExtractor.js +++ b/src/lib/defaultExtractor.js @@ -64,31 +64,41 @@ function* buildRegExps(context) { ]), ]) - yield regex.pattern([ - // Variants - '((?=((', - regex.any( - [ - regex.pattern([/([^...
diff --git a/tests/arbitrary-variants.test.js b/tests/arbitrary-variants.test.js --- a/tests/arbitrary-variants.test.js +++ b/tests/arbitrary-variants.test.js @@ -493,3 +493,37 @@ test('keeps escaped underscores in arbitrary variants mixed with normal variants `) }) }) + +test('allows attribute variants with q...
no css output for inline classes which specify an attribute value in an arbitrary variant <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you ...
2022-06-20T13:46:39Z
3.1
tailwindlabs/tailwindcss
8,622
tailwindlabs__tailwindcss-8622
[ "8610" ]
22eaad17c33583b841d2086a9386dd5c1770061c
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -14,6 +14,7 @@ import { version as tailwindVersion } from '../package.json' import log from './util/log' import { normalizeScreens } from './util/normalizeScreens' import { formatBoxShadowValue, parseBoxShadowVa...
diff --git a/tests/parallel-variants.test.js b/tests/parallel-variants.test.js --- a/tests/parallel-variants.test.js +++ b/tests/parallel-variants.test.js @@ -85,3 +85,52 @@ test('parallel variants can be generated using a function that returns parallel `) }) }) + +test('a function that returns parallel varian...
Safari ignores alpha channel in colors in `::marker`, which makes styling them with Tailwind impossible <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwin...
For anyone else that stumbles into this, the workaround I've found is to add this to my CSS file: ``` css ::marker { color: theme(colors.slate.500); } ``` But ideally this should be handled from the HTML to make it easier to manage together with the other styles. Looked at this quickly, it seems like the th...
2022-06-13T18:13:17Z
3.1
tailwindlabs/tailwindcss
8,448
tailwindlabs__tailwindcss-8448
[ "7800" ]
c4e443acc093d8980bf476f14255b793c5065b9a
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -1977,13 +1977,20 @@ export let corePlugins = { ) }, - ringWidth: ({ matchUtilities, addDefaults, addUtilities, theme }) => { - let ringOpacityDefault = theme('ringOpacity.DEFAULT', '0.5') - let ri...
diff --git a/tests/basic-usage.test.js b/tests/basic-usage.test.js --- a/tests/basic-usage.test.js +++ b/tests/basic-usage.test.js @@ -430,3 +430,237 @@ it('supports multiple backgrounds as arbitrary values even if only some are quot `) }) }) + +it('The "default" ring opacity is used by the default ring color ...
Default ringColor has opacity baked into it <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** v3.0.22 **What build tool (or f...
Hey! This is because `ringOpacity` has a `DEFAULT` of `0.5`. If you override that as well you get the result you want: https://play.tailwindcss.com/CwV0YGg3LS?file=config The whole `ringOpacity` thing isn’t really documented anymore though because we are encouraging the opacity modifier as of v3, so going to leav...
2022-05-26T23:36:32Z
3
tailwindlabs/tailwindcss
8,125
tailwindlabs__tailwindcss-8125
[ "7874" ]
e5ed08b5cbdd902dcbb7b25d7c32ad9b474ea1a8
diff --git a/src/lib/expandApplyAtRules.js b/src/lib/expandApplyAtRules.js --- a/src/lib/expandApplyAtRules.js +++ b/src/lib/expandApplyAtRules.js @@ -252,222 +252,228 @@ function processApply(root, context, localCache) { }) // Start the @apply process if we have rules with @apply in them - if (applies.length ...
diff --git a/tests/prefix.test.js b/tests/prefix.test.js --- a/tests/prefix.test.js +++ b/tests/prefix.test.js @@ -374,3 +374,29 @@ it('prefix does not detect and generate unnecessary classes', async () => { expect(result.css).toMatchFormattedCss(css``) }) + +it('supports prefixed utilities using arbitrary values...
Prefix option does not work with custom properties **What version of Tailwind CSS are you using?** v3.0.23 Hi ! I am trying to use the prefix option, but I have found a problem that prevents it to work for more complex patterns. For instance, here is a simple code _without_ any prefix: ``` .button { @ap...
To complement this issue, here are a few other use cases where CSS generation fails with prefix: ``` .accordion-content { @apply tw-ease-[cubic-bezier(0.77,0,0.175,1)]; } ``` Generates this incorrect markup: ``` { transition-timing-function: cubic-bezier(0.77,0,0.175,1); } ``` While the sam...
2022-04-15T20:19:59Z
3
tailwindlabs/tailwindcss
7,789
tailwindlabs__tailwindcss-7789
[ "7771" ]
c6097d59fcd3b4a176188327adee488c562ecb8f
diff --git a/src/lib/generateRules.js b/src/lib/generateRules.js --- a/src/lib/generateRules.js +++ b/src/lib/generateRules.js @@ -303,6 +303,19 @@ function looksLikeUri(declaration) { } } +function isParsableNode(node) { + let isParsable = true + + node.walkDecls((decl) => { + if (!isParsableCssValue(decl.n...
diff --git a/tests/arbitrary-values.test.js b/tests/arbitrary-values.test.js --- a/tests/arbitrary-values.test.js +++ b/tests/arbitrary-values.test.js @@ -370,3 +370,17 @@ it('should be possible to read theme values in arbitrary values (with quotes) wh `) }) }) + +it('should not output unparsable arbitrary CSS...
JIT analysis the comments code to add that classes instead of omit it <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** For exam...
Hey, this is covered in the docs: https://tailwindcss.com/docs/content-configuration#dynamic-class-names. Tailwind CSS does not interpret your source code so dynamic class names like this won't work. Ideally, we would just _not_ generate the CSS here since it's generating values that appear to result in a syntax error....
2022-03-08T17:17:23Z
3
tailwindlabs/tailwindcss
8,091
tailwindlabs__tailwindcss-8091
[ "8079" ]
1d4c5c78bd7b22f11753f216649bc12ce481d5e3
diff --git a/src/util/dataTypes.js b/src/util/dataTypes.js --- a/src/util/dataTypes.js +++ b/src/util/dataTypes.js @@ -42,10 +42,16 @@ export function normalize(value, isRoot = true) { // Add spaces around operators inside calc() that do not follow an operator // or '('. - return value.replace( - /(-?\d*\.?...
diff --git a/tests/normalize-data-types.test.js b/tests/normalize-data-types.test.js new file mode 100644 --- /dev/null +++ b/tests/normalize-data-types.test.js @@ -0,0 +1,42 @@ +import { normalize } from '../src/util/dataTypes' + +let table = [ + ['foo', 'foo'], + ['foo-bar', 'foo-bar'], + ['16/9', '16 / 9'], + + ...
Tailwind incorrect generate CSS variables as minus sign **What version of Tailwind CSS are you using?** 3.0.23 Hi, I am not sure if this issue is linked to the other problems I have reported in #7874 and #7884 as the output issue seems different. I am therefore opening a new issue. If I use the following CS...
Definitely seems like a bug and I think you’re right it’s probably because of the number! Will try to look at this this week 👍🏻
2022-04-11T21:39:57Z
3
tailwindlabs/tailwindcss
7,565
tailwindlabs__tailwindcss-7565
[ "4896" ]
af64d7190c1e3b4ed765c7464f99b6aec5d5bac2
diff --git a/src/lib/collapseAdjacentRules.js b/src/lib/collapseAdjacentRules.js --- a/src/lib/collapseAdjacentRules.js +++ b/src/lib/collapseAdjacentRules.js @@ -5,7 +5,7 @@ let comparisonMap = { let types = new Set(Object.keys(comparisonMap)) export default function collapseAdjacentRules() { - return (root) => {...
diff --git a/tests/apply.test.js b/tests/apply.test.js --- a/tests/apply.test.js +++ b/tests/apply.test.js @@ -1289,9 +1289,6 @@ it('apply partitioning works with media queries', async () => { body { --tw-text-opacity: 1; color: rgb(220 38 38 / var(--tw-text-opacity)); - } - html, - ...
Duplicated CSS rules in @media output ### What version of Tailwind CSS are you using? 2.2.4 ### What build tool (or framework if it abstracts the build tool) are you using? Gulp and tailwindcss-cli ### What version of Node.js are you using? v14.17.2 ### What browser are you using? N/A ### What operating system ...
Updating this issue with some additional observations from my local development. When running JIT watch mode (via `npx tailwindcss`), I get many duplicated CSS rules. Still trying to drilldown to what specific actions cause this, but it seems to be related to tailwind watching my content files (Blade views in this c...
2022-02-21T16:58:26Z
3
tailwindlabs/tailwindcss
7,291
tailwindlabs__tailwindcss-7291
[ "7207" ]
cd8f109981ed64ec78fb70b3091153f45931ff27
diff --git a/src/index.js b/src/index.js --- a/src/index.js +++ b/src/index.js @@ -13,7 +13,21 @@ module.exports = function tailwindcss(configOrPath) { return root }, function (root, result) { - processTailwindFeatures(setupTrackingContext(configOrPath))(root, result) + let cont...
diff --git a/tests/variants.test.js b/tests/variants.test.js --- a/tests/variants.test.js +++ b/tests/variants.test.js @@ -1,5 +1,6 @@ import fs from 'fs' import path from 'path' +import postcss from 'postcss' import { run, css, html, defaults } from './util/run' @@ -568,3 +569,37 @@ test('The visited variant re...
Variant nodes are appended to the document rather than a root **What version of Tailwind CSS are you using?** 3.0.16 **What build tool (or framework if it abstracts the build tool) are you using?** postcss-cli 9.1.0 **What version of Node.js are you using?** 17.x **Reproduction URL** See the reprod...
``` /** * Use this directive to control where Tailwind injects the hover, focus, * responsive, dark mode, and other variants of each class. * * If omitted, Tailwind will append these classes to the very end of * your stylesheet by default. */ @tailwind variants; ``` @ma-g-ma maybe this is it! and i've...
2022-02-01T20:06:03Z
3
tailwindlabs/tailwindcss
7,163
tailwindlabs__tailwindcss-7163
[ "7149" ]
10103d8bafdb401da417fd13b19dd426f612340f
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -3,6 +3,7 @@ import * as path from 'path' import postcss from 'postcss' import createUtilityPlugin from './util/createUtilityPlugin' import buildMediaQuery from './util/buildMediaQuery' +import escapeClassName f...
diff --git a/tests/animations.test.js b/tests/animations.test.js --- a/tests/animations.test.js +++ b/tests/animations.test.js @@ -181,3 +181,96 @@ test('multiple custom', () => { `) }) }) + +test('with dots in the name', () => { + let config = { + content: [ + { + raw: html` + <div cl...
Wrong keyframe keys when generationg CSS classes with JS <!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** For example: v3.0.15 ...
Hey, @Mastercuber. What you're seeing there isn't the "wrong key" per se. Tailwind is mistakenly trying to prefix the "." in your animation value and keyframe name when it should instead be escaping them and then prefixing. I will send the Tailwind team a PR to address this.
2022-01-22T01:00:18Z
3
tailwindlabs/tailwindcss
6,519
tailwindlabs__tailwindcss-6519
[ "6436" ]
fb545bc94de9e8baf33990b71d87df0c269dce22
diff --git a/src/lib/evaluateTailwindFunctions.js b/src/lib/evaluateTailwindFunctions.js --- a/src/lib/evaluateTailwindFunctions.js +++ b/src/lib/evaluateTailwindFunctions.js @@ -42,7 +42,7 @@ function validatePath(config, path, defaultValue) { ? pathToString(path) : path.replace(/^['"]+/g, '').replace(/['"]+...
diff --git a/tests/evaluateTailwindFunctions.test.js b/tests/evaluateTailwindFunctions.test.js --- a/tests/evaluateTailwindFunctions.test.js +++ b/tests/evaluateTailwindFunctions.test.js @@ -31,6 +31,111 @@ test('it looks up values in the theme using dot notation', () => { }) }) +test('it looks up values in the t...
v2 to v3 theme() keys bug? **What version of Tailwind CSS are you using?** v3.0.1 **What build tool (or framework if it abstracts the build tool) are you using?** vue cli v5.x webpack v5.x **What version of Node.js are you using?** v16.5.0 **What browser are you using?** N/A **What operating sys...
I think it's wrong to use array in object definition, try with this. ``` module.exports = { theme: { spacing: { "4.5": "1.125rem" }, } } ``` By the way why are you using space in font size? and if you want to not override default spacing values you need to extend the theme this way ``...
2021-12-14T22:26:30Z
3
tailwindlabs/tailwindcss
6,469
tailwindlabs__tailwindcss-6469
[ "6395" ]
4b2482ff3550ec7ca74561f8ae84d4d826cca762
diff --git a/src/lib/generateRules.js b/src/lib/generateRules.js --- a/src/lib/generateRules.js +++ b/src/lib/generateRules.js @@ -248,6 +248,21 @@ function parseRules(rule, cache, options = {}) { return [cache.get(rule), options] } +const IS_VALID_PROPERTY_NAME = /^[a-z_-]/ + +function isValidPropName(name) { + ...
diff --git a/tests/arbitrary-properties.test.js b/tests/arbitrary-properties.test.js --- a/tests/arbitrary-properties.test.js +++ b/tests/arbitrary-properties.test.js @@ -231,3 +231,45 @@ test('invalid class', () => { expect(result.css).toMatchFormattedCss(css``) }) }) + +test('invalid arbitrary property', () ...
Abnormal css ouput when some string in the code is wrapped in square brackets **What version of Tailwind CSS are you using?** v3.0.1 **What build tool (or framework if it abstracts the build tool) are you using?** Next.js 12.0.4, postcss 8.4.4 **What version of Node.js are you using?** v14.18.1 **What...
This is probably because of [arbitrary properties](https://tailwindcss.com/docs/adding-custom-styles#arbitrary-properties). you can just add an unnecessary escape: ```ts const ProblemComponent = () => { return ( <button nCanPlay={(event: any) => { console.debug(`player ready: [autoplay\:${...
2021-12-13T17:36:20Z
3
tailwindlabs/tailwindcss
5,470
tailwindlabs__tailwindcss-5470
[ "5458" ]
30badadd211594ccc83c686e3f4c1f06a7e107c9
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -1014,7 +1014,11 @@ export let divideColor = ({ matchUtilities, theme, corePlugins }) => { { divide: (value) => { if (!corePlugins('divideOpacity')) { - return { ['& > :not([hidden]) ~...
diff --git a/tests/opacity.test.css b/tests/opacity.test.css deleted file mode 100644 --- a/tests/opacity.test.css +++ /dev/null @@ -1,15 +0,0 @@ -.divide-black > :not([hidden]) ~ :not([hidden]) { - border-color: #000; -} -.border-black { - border-color: #000; -} -.bg-black { - background-color: #000; -} -.text-blac...
Disabling an opacity plugin breaks support for custom property colors ### What version of Tailwind CSS are you using? 2.2.7 ### What build tool (or framework if it abstracts the build tool) are you using? Tailwind Play ### What version of Node.js are you using? n/a ### What browser are you using? n/a ### What o...
A workaround is to provide an empty theme instead of disabling the opacity plugin, for example `backgroundOpacity: {}`.
2021-09-10T13:28:31Z
2.2
tailwindlabs/tailwindcss
5,245
tailwindlabs__tailwindcss-5245
[ "5177" ]
d13b0e1085f2e526b8c5b49371b9e1b11d29b472
diff --git a/src/plugins/objectPosition.js b/src/plugins/objectPosition.js --- a/src/plugins/objectPosition.js +++ b/src/plugins/objectPosition.js @@ -1,5 +1,8 @@ import createUtilityPlugin from '../util/createUtilityPlugin' +import { asList } from '../util/pluginUtils' export default function () { - return create...
diff --git a/tests/jit/arbitrary-values.test.css b/tests/jit/arbitrary-values.test.css --- a/tests/jit/arbitrary-values.test.css +++ b/tests/jit/arbitrary-values.test.css @@ -260,6 +260,12 @@ .stroke-\[\#da5b66\] { stroke: #da5b66; } +.object-\[50\%\2c 50\%\] { + object-position: 50% 50%; +} +.object-\[top\2c rig...
Object Position in JIT mode ### What version of Tailwind CSS are you using? 2.2.4 ### What build tool (or framework if it abstracts the build tool) are you using? Vite (with SvelteKit) ### What version of Node.js are you using? v14.17.3 ### What browser are you using? Safari, Firefox ### What operating system a...
2021-08-18T09:56:11Z
2.2
tailwindlabs/tailwindcss
4,852
tailwindlabs__tailwindcss-4852
[ "4849" ]
b417e336387bfbc005294c57fd780d893ff87639
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -1,14 +1,23 @@ import * as plugins from './plugins/index.js' import configurePlugins from './util/configurePlugins' -function move(items, item, before) { - if (items.indexOf(item) === -1) { +function move(item...
diff --git a/tests/fixtures/tailwind-output-flagged.css b/tests/fixtures/tailwind-output-flagged.css --- a/tests/fixtures/tailwind-output-flagged.css +++ b/tests/fixtures/tailwind-output-flagged.css @@ -6941,32 +6941,6 @@ video { border-collapse: separate; } -.transform { - --tw-translate-x: 0; - --tw-translate...
Wrong rules order for filter utility with only one filter enabled ### What version of Tailwind CSS are you using? v2.2.4 ### What build tool (or framework if it abstracts the build tool) are you using? webpack 4.46.0 ### What version of Node.js are you using? v14.1.0 ### What browser are you using? Chrome ### W...
2021-07-01T09:51:32Z
2.2
tailwindlabs/tailwindcss
4,471
tailwindlabs__tailwindcss-4471
[ "4400" ]
89b9e3406f32dcc35da889a57ac852f3a3be88f2
diff --git a/src/jit/index.js b/src/jit/index.js --- a/src/jit/index.js +++ b/src/jit/index.js @@ -1,16 +1,8 @@ -import postcss from 'postcss' - -import evaluateTailwindFunctions from '../lib/evaluateTailwindFunctions' -import substituteScreenAtRules from '../lib/substituteScreenAtRules' - import normalizeTailwindDire...
diff --git a/integrations/parcel/tests/integration.test.js b/integrations/parcel/tests/integration.test.js --- a/integrations/parcel/tests/integration.test.js +++ b/integrations/parcel/tests/integration.test.js @@ -33,7 +33,7 @@ describe('static build', () => { }) }) -describe('watcher', () => { +describe.skip('w...
[Bug]: JIT doesn't work as expected with multiple entry points importing CSS in Webpack ### What version of Tailwind CSS are you using? v2.1.2 ### What build tool (or framework if it abstracts the build tool) are you using? Webpack 5.27.2 ### What version of Node.js are you using? 14.16.0 ### What bro...
2021-05-26T13:29:46Z
2.1
tailwindlabs/tailwindcss
4,263
tailwindlabs__tailwindcss-4263
[ "4096" ]
76c670fc2913eb03a340a015d30d3db53cca9c22
diff --git a/src/jit/lib/generateRules.js b/src/jit/lib/generateRules.js --- a/src/jit/lib/generateRules.js +++ b/src/jit/lib/generateRules.js @@ -192,9 +192,13 @@ function* resolveMatchedPlugins(classCandidate, context) { } } +function splitWithSeparator(input, separator) { + return input.split(new RegExp(`\\${...
diff --git a/tests/jit/arbitrary-values.test.css b/tests/jit/arbitrary-values.test.css --- a/tests/jit/arbitrary-values.test.css +++ b/tests/jit/arbitrary-values.test.css @@ -269,12 +269,18 @@ .text-\[2\.23rem\] { font-size: 2.23rem; } +.text-\[length\:var\(--font-size\)\] { + font-size: var(--font-size); +} .le...
[JIT] font/text size does not support css variables ### What version of Tailwind CSS are you using? 2.1.0 ### What build tool (or framework if it abstracts the build tool) are you using? postcss8 ### What version of Node.js are you using? 15.14.0 ### What browser are you using? Firefox ### What operating system...
Yeah this is tough because of naming conflicts. Tailwind has classes like `text-sm` but also `text-black`, so when you say `text-[var(--foo)]` we don't know if that is a color or a font-size. I think one way we could solve this is having a dedicated plugin for handling arbitrary text values that generates this: `...
2021-05-06T19:34:43Z
2.1
tailwindlabs/tailwindcss
4,214
tailwindlabs__tailwindcss-4214
[ "3948" ]
e764df5055b7e4a1f2edb72d38b76b338d0e2f13
diff --git a/src/index.js b/src/index.js --- a/src/index.js +++ b/src/index.js @@ -97,7 +97,7 @@ module.exports = function (config) { return { postcssPlugin: 'tailwindcss', - plugins: [...plugins, processTailwindFeatures(getConfig), formatCSS], + plugins: [...plugins, processTailwindFeatures(getConfig, ...
diff --git a/tests/fixtures/custom-purge-config.js b/tests/fixtures/custom-purge-config.js new file mode 100644 --- /dev/null +++ b/tests/fixtures/custom-purge-config.js @@ -0,0 +1,20 @@ +module.exports = { + purge: ['./*.html'], + theme: { + extend: { + colors: { + 'black!': '#000', + }, + s...
Not all classes are being pulled in from Blade files, some only after re-saving the files. ### What version of @tailwindcss/jit are you using? 0.1.3 ### What version of Node.js are you using? v14.16.0 ### What browser are you using? Chrome ### What operating system are you using? macOS ### Reproduction reposito...
> You don't have package.json or package-lock.json in your repo. `npm install` won't work. Perhaps it was unclear, but those files are also located in the subfolder `resources/myfolder`. In our project we have multiple frontends which means we have multiple package.json etc that are located in other subfolders like ...
2021-04-30T17:33:03Z
2.1
tailwindlabs/tailwindcss
2,951
tailwindlabs__tailwindcss-2951
[ "2911", "2911" ]
ba753cf1721af9314e2a41fdf932a121cd6add95
diff --git a/src/plugins/ringOffsetColor.js b/src/plugins/ringOffsetColor.js --- a/src/plugins/ringOffsetColor.js +++ b/src/plugins/ringOffsetColor.js @@ -7,7 +7,7 @@ export default function () { return function ({ addUtilities, theme, variants }) { const colors = flattenColorPalette(theme('ringOffsetColor')) ...
diff --git a/__tests__/plugins/ringWidth.test.js b/__tests__/plugins/ringWidth.test.js new file mode 100644 --- /dev/null +++ b/__tests__/plugins/ringWidth.test.js @@ -0,0 +1,104 @@ +import invokePlugin from '../util/invokePlugin' +import plugin from '../../src/plugins/ringWidth' + +test('ring widths', () => { + const...
Missing DEFAULT option for ringOffsetWidth and ringOffsetColor ### Describe the problem: Trying to set a default ring with offset doesn't work. ### Link to a minimal reproduction: https://play.tailwindcss.com/hNYXW0Qzj9 Missing DEFAULT option for ringOffsetWidth and ringOffsetColor ### Describe the problem: ...
Hey! 👋 There is no offset specified in your Play example, only the `ring` itself (defaulting to 3px). The actual "default" for ring-offset is no offset. We make the assumption that there should be no offset, unless explicitly specified. The default color for ring offset is white. 👍 If you add a `ring-offset...
2020-11-30T14:41:41Z
2
tailwindlabs/tailwindcss
2,331
tailwindlabs__tailwindcss-2331
[ "2258" ]
6a39e3650d65bfcbada7acc95bd865c5babb543e
diff --git a/src/lib/purgeUnusedStyles.js b/src/lib/purgeUnusedStyles.js --- a/src/lib/purgeUnusedStyles.js +++ b/src/lib/purgeUnusedStyles.js @@ -77,10 +77,18 @@ export default function purgeUnusedUtilities(config, configChanged) { ? ['utilities'] : _.get(config, 'purge.layers', ['base', 'compone...
diff --git a/__tests__/purgeUnusedStyles.test.js b/__tests__/purgeUnusedStyles.test.js --- a/__tests__/purgeUnusedStyles.test.js +++ b/__tests__/purgeUnusedStyles.test.js @@ -195,19 +195,19 @@ test('custom css in a layer is purged by default when using layers mode', () => ]) .process( ` - ...
PurgeCSS remove first components class when using whitelist comment Hi tailwindlabs team, I noticed the following point with the building PurgeCSS. If I import a CSS file before `@tailwind components;` and use PurgeCSS whitelist comment: `.container` classes are remove but not responsive container classes. My...
I can use `mode: all` + PurgeCSS comment as a work around. Can you create a simple project that reproduces the issue? We got a lot of issues that require me to manually recreate someone's project from scratch and I unfortunately just don't have time for that so things end up going unfixed. If you can provide something ...
2020-09-06T03:30:01Z
1.8
tailwindlabs/tailwindcss
2,322
tailwindlabs__tailwindcss-2322
[ "2319" ]
8e49e484df0ae1bfba3c92c812481c7d54941c35
diff --git a/src/index.js b/src/index.js --- a/src/index.js +++ b/src/index.js @@ -17,9 +17,9 @@ import uniformColorPalette from './flagged/uniformColorPalette.js' import extendedSpacingScale from './flagged/extendedSpacingScale.js' import defaultLineHeights from './flagged/defaultLineHeights.js' import extendedFont...
diff --git a/__tests__/darkMode.test.js b/__tests__/darkMode.test.js --- a/__tests__/darkMode.test.js +++ b/__tests__/darkMode.test.js @@ -49,6 +49,34 @@ test('generating dark mode variants uses the media strategy by default', () => { }) }) +test('dark mode variants can be generated even when the user has their o...
Tailwindcss v1.8 dark mode (experimental) issue ### Describe the problem: 🚫 Error: Your config mentions the "dark" variant, but "dark" doesn't appear to be a variant. Did you forget or misconfigure a plugin that supplies that variant? <!-- Explain the behavior you're seeing that you think is a bug, and explain ...
Having the same issue. ``` module.exports = { ... dark: 'media' experimental: { darkModeVariant: true, }, } ``` We're looking into it!
2020-09-04T23:54:51Z
1.8
tailwindlabs/tailwindcss
2,271
tailwindlabs__tailwindcss-2271
[ "2192" ]
0b48b4cd8c79cbe8b0505ffc727c398a298857db
diff --git a/src/flagged/applyComplexClasses.js b/src/flagged/applyComplexClasses.js --- a/src/flagged/applyComplexClasses.js +++ b/src/flagged/applyComplexClasses.js @@ -95,7 +95,7 @@ function buildUtilityMap(css, lookupTree) { let index = 0 const utilityMap = {} - lookupTree.walkRules(rule => { + function h...
diff --git a/__tests__/applyComplexClasses.test.js b/__tests__/applyComplexClasses.test.js --- a/__tests__/applyComplexClasses.test.js +++ b/__tests__/applyComplexClasses.test.js @@ -996,3 +996,101 @@ test('you can apply classes to a rule with multiple selectors', () => { expect(result.warnings().length).toBe(0) ...
applyComplexClasses compiler stuck with @apply inside media queries or variants ### Describe the problem: With the new applyComplexClasses if you put `@apply` **the old way**: inside a `@screen` (media query) or a `&:hover` (variant), the complier gets stuck (using postcss loader in webpack). ### Link to a minima...
This should be fixed mainly because it bugs also when you apply custom selectors where you don't have variants in the `@apply`: ``` .selector { @screen lg { @apply overflow-sub; } } ``` Where `@apply lg:overflow-sub` is not possible when you don't want to set up apply variants for this selector. Thi...
2020-08-28T15:24:50Z
1.8
tailwindlabs/tailwindcss
2,211
tailwindlabs__tailwindcss-2211
[ "2190" ]
2903811767fa03f559e644b5732f0ec3af32f3fd
diff --git a/src/flagged/applyComplexClasses.js b/src/flagged/applyComplexClasses.js --- a/src/flagged/applyComplexClasses.js +++ b/src/flagged/applyComplexClasses.js @@ -39,7 +39,7 @@ const tailwindApplyPlaceholder = selectorParser.attribute({ attribute: '__TAILWIND-APPLY-PLACEHOLDER__', }) -function generateRul...
diff --git a/__tests__/applyComplexClasses.test.js b/__tests__/applyComplexClasses.test.js --- a/__tests__/applyComplexClasses.test.js +++ b/__tests__/applyComplexClasses.test.js @@ -848,3 +848,35 @@ test('you can apply utility classes when a selector is used for the important op expect(result.warnings().length).t...
Using @apply with variants doesn't work properly with group selectors Loving the new features in 1.7 so far, thank you! Came across what seems to be an issue with the new `applyComplexClasses` feature, in that when a variant class (e.g. `hover:bg-red-400`) is applied to a rule for a group selector, the variant modif...
Same issue here. ![image](https://user-images.githubusercontent.com/12186284/90762103-bd9faa80-e2e4-11ea-8bd9-f11dee3ad1d5.png) A related issue I think is this strange behavior when applying a selector when chaining selectors: ``` .foo, .selector { color: red; } .custom { @apply selector; } ``` `@...
2020-08-20T20:29:32Z
1.7
tailwindlabs/tailwindcss
2,108
tailwindlabs__tailwindcss-2108
[ "2103" ]
f8d7f245d5e49af84c0d9f12448781e64ab4e66d
diff --git a/src/plugins/animation.js b/src/plugins/animation.js --- a/src/plugins/animation.js +++ b/src/plugins/animation.js @@ -1,14 +1,14 @@ import _ from 'lodash' export default function() { - return function({ addBase, addUtilities, e, theme, variants }) { + return function({ addUtilities, e, theme, variant...
diff --git a/__tests__/fixtures/tailwind-output-ie11.css b/__tests__/fixtures/tailwind-output-ie11.css --- a/__tests__/fixtures/tailwind-output-ie11.css +++ b/__tests__/fixtures/tailwind-output-ie11.css @@ -577,50 +577,6 @@ video { height: auto; } -@keyframes spin { - from { - transform: rotate(0deg); - } - ...
missing Keyframe css for animations if @tailwind base is missing Just upgraded to 1.6.0 and the animation css is generated but not the matching keyframe css - this is for the default animations and any custom ones I create. This is the case with a blank config file. I have used everything else fine with no @tailw...
2020-08-02T12:02:53Z
1.6
tailwindlabs/tailwindcss
2,075
tailwindlabs__tailwindcss-2075
[ "1957" ]
4ee53f315adde5e8471162e7b8a814faafef95dd
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -46,6 +46,7 @@ import objectPosition from './plugins/objectPosition' import opacity from './plugins/opacity' import outline from './plugins/outline' import overflow from './plugins/overflow' +import overscroll f...
diff --git a/__tests__/fixtures/tailwind-output-ie11.css b/__tests__/fixtures/tailwind-output-ie11.css --- a/__tests__/fixtures/tailwind-output-ie11.css +++ b/__tests__/fixtures/tailwind-output-ie11.css @@ -6089,6 +6089,42 @@ video { -webkit-overflow-scrolling: auto; } +.overscroll-auto { + overscroll-behavior: ...
[Feature request] Add overscroll options On mobile UIs, you can have something called [`overscroll-behaviour`](https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior) which can help on removing 'pull to refresh' when scrolling. It is also useful for chat boxes or other contained UI elements - see [this...
This can easily be added as a plugin in the short term: ```js const plugin = require('tailwindcss/plugin'); module.exports = { plugins: [ plugin(function ({ addUtilities }) { const newUtilities = { '.overscroll-auto': { 'overscroll-behavior': 'auto...
2020-07-25T19:33:32Z
1.5
tailwindlabs/tailwindcss
1,083
tailwindlabs__tailwindcss-1083
[ "1082" ]
c2dcecfff6753805cec7ad4610de56ebc71d86e3
diff --git a/src/plugins/justifyContent.js b/src/plugins/justifyContent.js --- a/src/plugins/justifyContent.js +++ b/src/plugins/justifyContent.js @@ -17,6 +17,9 @@ export default function() { '.justify-around': { 'justify-content': 'space-around', }, + '.justify-evenly': { + ...
diff --git a/__tests__/fixtures/tailwind-output-important.css b/__tests__/fixtures/tailwind-output-important.css --- a/__tests__/fixtures/tailwind-output-important.css +++ b/__tests__/fixtures/tailwind-output-important.css @@ -3456,6 +3456,10 @@ video { justify-content: space-around !important; } +.justify-evenly...
[Feature Proposal] justify-content: space-evenly Hey all, this is a feature request (and PR) to add a utility for `justify-content: space evenly`, named `justify-evenly`. MDN describes the functionality as: > The items are evenly distributed within the alignment container along the main axis. The spacing betwe...
2019-08-18T07:44:46Z
1.1
tailwindlabs/tailwindcss
1,680
tailwindlabs__tailwindcss-1680
[ "1670" ]
52aab172db0df48883368b243b7073759b05e402
diff --git a/scripts/rebuildFixtures.js b/scripts/rebuildFixtures.js --- a/scripts/rebuildFixtures.js +++ b/scripts/rebuildFixtures.js @@ -44,6 +44,19 @@ Promise.all([ to: '__tests__/fixtures/tailwind-output-ie11.css', config: { target: 'ie11' }, }), + build({ + from: '__tests__/fixtures/tailwind-input...
diff --git a/__tests__/fixtures/tailwind-output-no-color-opacity.css b/__tests__/fixtures/tailwind-output-no-color-opacity.css new file mode 100644 --- /dev/null +++ b/__tests__/fixtures/tailwind-output-no-color-opacity.css @@ -0,0 +1,57055 @@ +/*! normalize.css v8.0.1 | MIT License | github.com/necolas/normalize.css *...
[v1.4] Turning off opacity in corePlugins config still generates CSS variables The generated CSS file has increased substantially in size (~40%) as a result and I can't seem to turn it off. **tailwind.config.js** ```js corePlugins: { divideOpacity: false, backgroundOpacity: false, borderOpacity: fal...
Same here. Disabling the core-modules only removes the corresponding classes `.bg-opacity-*`, `.text-opacity-*` and so on. Seems like there should be a check here (and the other plugins): https://github.com/tailwindcss/tailwindcss/blob/e52c59a7588a17c04c250fc3d41c182678895061/src/plugins/backgroundColor.js#L23-L27...
2020-05-01T19:10:59Z
1.4
tailwindlabs/tailwindcss
1,094
tailwindlabs__tailwindcss-1094
[ "1074" ]
28dab5eb3a797b38aaba12d8c5fcb06ca651dc45
diff --git a/src/corePlugins.js b/src/corePlugins.js --- a/src/corePlugins.js +++ b/src/corePlugins.js @@ -50,6 +50,7 @@ import resize from './plugins/resize' import boxShadow from './plugins/boxShadow' import fill from './plugins/fill' import stroke from './plugins/stroke' +import strokeWidth from './plugins/stroke...
diff --git a/__tests__/fixtures/tailwind-output-important.css b/__tests__/fixtures/tailwind-output-important.css --- a/__tests__/fixtures/tailwind-output-important.css +++ b/__tests__/fixtures/tailwind-output-important.css @@ -6758,6 +6758,26 @@ video { stroke: currentColor !important; } +.stroke-w-0 { + stroke-...
[Proposal] Add `stroke-width` It's quite nice to customize feather icons using `stroke-width`. The default is `2`, but setting it to `1` make large icons much nicer to look at. Could this be added to Tailwind?
I found a solution and i'll make pull request
2019-08-22T21:15:02Z
1.2
tailwindlabs/tailwindcss
1,799
tailwindlabs__tailwindcss-1799
[ "1797" ]
ae8b634f332a4290436ba13a8eac6f0a42853d14
diff --git a/src/lib/evaluateTailwindFunctions.js b/src/lib/evaluateTailwindFunctions.js --- a/src/lib/evaluateTailwindFunctions.js +++ b/src/lib/evaluateTailwindFunctions.js @@ -1,6 +1,34 @@ import _ from 'lodash' import functions from 'postcss-functions' +function findClosestExistingPath(theme, path) { + const p...
diff --git a/__tests__/themeFunction.test.js b/__tests__/themeFunction.test.js --- a/__tests__/themeFunction.test.js +++ b/__tests__/themeFunction.test.js @@ -110,6 +110,61 @@ test('an unquoted list is valid as a default value', () => { }) }) +test('A missing root theme value throws', () => { + const input = ` +...
Is it intentional that `theme()` doesn't throw when property doesn't exist? This seems like maybe a bug, or at least an undocumented design choice. I was expecting `theme` to provide safety rails against typos or unexpected theme breakage by throwing an error if you try and get something that doesn't exist from the con...
Could definitely make it throw when someone asks for a key that doesn't exist 👍 Would accept a PR for it for sure.
2020-05-19T17:06:41Z
1.9
tailwindlabs/tailwindcss
992
tailwindlabs__tailwindcss-992
[ "982" ]
afa2b50dc2a213591d369ff1e7fa59fa6c18a0cc
diff --git a/src/plugins/boxShadow.js b/src/plugins/boxShadow.js --- a/src/plugins/boxShadow.js +++ b/src/plugins/boxShadow.js @@ -1,12 +1,14 @@ import _ from 'lodash' +import prefixNegativeModifiers from '../util/prefixNegativeModifiers' export default function() { return function({ addUtilities, e, theme, vari...
diff --git a/__tests__/plugins/boxShadow.test.js b/__tests__/plugins/boxShadow.test.js new file mode 100644 --- /dev/null +++ b/__tests__/plugins/boxShadow.test.js @@ -0,0 +1,63 @@ +import _ from 'lodash' +import escapeClassName from '../../src/util/escapeClassName' +import plugin from '../../src/plugins/boxShadow' + +...
[Feature Request] Support negative prefix syntax in config for letterSpacing and boxShadow ### Background When I'm using letter spacing utilities, I prefer numerical class names like `tracking-1`, `tracking-2`, etc. instead of `wide`, `wider`, etc. I also like to set my negative letter spacing values to `-tracking...
Happy to accept a PR for this, it's probably technically a breaking change but it's just as much a bugfix IMO 👍
2019-06-28T01:59:42Z
1
tailwindlabs/tailwindcss
847
tailwindlabs__tailwindcss-847
[ "817" ]
c88c187ca447491eb557f27b3e38f0df393a8710
diff --git a/src/index.js b/src/index.js --- a/src/index.js +++ b/src/index.js @@ -3,10 +3,10 @@ import fs from 'fs' import _ from 'lodash' import postcss from 'postcss' -import perfectionist from 'perfectionist' import registerConfigAsDependency from './lib/registerConfigAsDependency' import processTailwindFea...
diff --git a/__tests__/fixtures/tailwind-output-important.css b/__tests__/fixtures/tailwind-output-important.css --- a/__tests__/fixtures/tailwind-output-important.css +++ b/__tests__/fixtures/tailwind-output-important.css @@ -39,7 +39,7 @@ main { h1 { font-size: 2em; - margin: .67em 0; + margin: 0.67em 0; } ...
Error when adding comments between @apply `foo.css`: ```css .btn { @apply flex w-20 py-1 justify-center items-center; /* it works without this line */ @apply border border-gray-200 rounded; } ``` <img width="1464" alt="屏幕快照 2019-04-02 下午1 43 48" src="https://user-images.githubusercontent.com/8784712/5...
2019-04-16T15:45:36Z
1
tailwindlabs/tailwindcss
681
tailwindlabs__tailwindcss-681
[ "571" ]
f987d5386de23a836f1ba8a8aab818cda46f0139
diff --git a/src/plugins/whitespace.js b/src/plugins/whitespace.js --- a/src/plugins/whitespace.js +++ b/src/plugins/whitespace.js @@ -8,8 +8,11 @@ export default function({ variants }) { '.whitespace-pre-line': { 'white-space': 'pre-line' }, '.whitespace-pre-wrap': { 'white-space': 'pre-wrap' }, - ...
diff --git a/__tests__/fixtures/tailwind-output-important.css b/__tests__/fixtures/tailwind-output-important.css --- a/__tests__/fixtures/tailwind-output-important.css +++ b/__tests__/fixtures/tailwind-output-important.css @@ -6019,12 +6019,20 @@ table { white-space: pre-wrap !important; } -.break-words { - word...
Add break-all utility, change word-wrap to overflow-wrap 👋 Fix #411 This PR: - Adds a `.break-all` class - Changes `word-wrap` to `overflow-wrap` (https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap) Thanks!
Docs updated in [#47.](https://github.com/tailwindcss/docs/pull/47) Thanks for this! I really want to merge it but there's an annoying decision we have to figure out... Right now you can use `break-normal` to "undo" `break-words` at various breakpoints, like: ``` <div class="break-words md:break-normal">...</div...
2019-02-22T16:59:19Z
0.7
tailwindlabs/tailwindcss
516
tailwindlabs__tailwindcss-516
[ "150" ]
38c211a164fe03bef2fb844792c134d93a415c8e
diff --git a/src/lib/substituteClassApplyAtRules.js b/src/lib/substituteClassApplyAtRules.js --- a/src/lib/substituteClassApplyAtRules.js +++ b/src/lib/substituteClassApplyAtRules.js @@ -15,40 +15,57 @@ function buildClassTable(css) { return classTable } +function buildShadowTable(generatedUtilities) { + const u...
diff --git a/__tests__/applyAtRule.test.js b/__tests__/applyAtRule.test.js --- a/__tests__/applyAtRule.test.js +++ b/__tests__/applyAtRule.test.js @@ -1,8 +1,12 @@ import postcss from 'postcss' import plugin from '../src/lib/substituteClassApplyAtRules' +import generateUtilities from '../src/util/generateUtilities' +...
Consider not relying on previously defined mixin in file for "@apply" Currently `@apply` works by walking through all previously defined "mixins"[1] in the file before substituting the found ones, which constrains you to either only use one file, or to import all of your css in one place [2] before defining your custom...
I tried using https://github.com/ben-eb/postcss-discard-duplicates to discard the duplicate code created by `@tailwind utilities;` but unfortunately it just did not work for me at all. Has anyone else been able to get it to work? The only other option would be to have the core include a "reverse parser", something t...
2018-07-11T16:00:30Z
0.6
tailwindlabs/tailwindcss
497
tailwindlabs__tailwindcss-497
[ "464" ]
62994fc022ef21c4db2f7e0b958eed10405fb447
diff --git a/src/lib/substituteResponsiveAtRules.js b/src/lib/substituteResponsiveAtRules.js --- a/src/lib/substituteResponsiveAtRules.js +++ b/src/lib/substituteResponsiveAtRules.js @@ -2,7 +2,7 @@ import _ from 'lodash' import postcss from 'postcss' import cloneNodes from '../util/cloneNodes' import buildMediaQuer...
diff --git a/__tests__/responsiveAtRule.test.js b/__tests__/responsiveAtRule.test.js new file mode 100644 --- /dev/null +++ b/__tests__/responsiveAtRule.test.js @@ -0,0 +1,245 @@ +import postcss from 'postcss' +import plugin from '../src/lib/substituteResponsiveAtRules' +import config from '../defaultConfig.stub.js' + ...
State Variant with Responsive Prefix does not work with group-hover ## Steps to reproduce ### Create element Create an element with: ```html <div class="group bg-red p-8"> <div class="hidden md:group-hover:block bg-blue p-4"> Only visible when group is hovered </div> </div> ``` ### Enable `...
*Copying this over from duplicate issue #468 so I can close that one.* --- Right now if you have `responsive` and `group-hover` variants enabled for a module, you'll get selectors like: ``` @media (min-width: 768px) { .md\:group:hover .group-hover\:bg-blue { background-color: blue } } ``` I th...
2018-06-20T16:25:43Z
0.5
tailwindlabs/tailwindcss
418
tailwindlabs__tailwindcss-418
[ "256" ]
fa0e06c2dd5182ab27311f4526fb083afaea1682
diff --git a/defaultConfig.stub.js b/defaultConfig.stub.js --- a/defaultConfig.stub.js +++ b/defaultConfig.stub.js @@ -864,15 +864,18 @@ module.exports = { | Plugins https://tailwindcss.com/docs/plugins |----------------------------------------------------------------------------- ...
diff --git a/__tests__/fixtures/tailwind-input.css b/__tests__/fixtures/tailwind-input.css --- a/__tests__/fixtures/tailwind-input.css +++ b/__tests__/fixtures/tailwind-input.css @@ -1,5 +1,7 @@ @tailwind preflight; +@tailwind components; + @tailwind utilities; @responsive {
Disable Container module Hi, Can I ignore the container class output in tailwind.js? Thanks, Gabor
Right now it's not possible to disable the container module but we're planning to make it possible soon. In the mean time, just choose a different class name for your own container and don't use the `.container` class 👍 Thanks @adamwathan
2018-03-12T17:30:27Z
0.4
tailwindlabs/tailwindcss
255
tailwindlabs__tailwindcss-255
[ "247" ]
cbe89ea6eed75eea4889d2178a940041c316073b
diff --git a/defaultConfig.stub.js b/defaultConfig.stub.js --- a/defaultConfig.stub.js +++ b/defaultConfig.stub.js @@ -775,6 +775,7 @@ module.exports = { appearance: ['responsive'], backgroundColors: ['responsive', 'hover'], backgroundPosition: ['responsive'], + backgroundRepeat: ['responsive'], ...
diff --git a/__tests__/fixtures/tailwind-output.css b/__tests__/fixtures/tailwind-output.css --- a/__tests__/fixtures/tailwind-output.css +++ b/__tests__/fixtures/tailwind-output.css @@ -1235,6 +1235,22 @@ button, background-position: top; } +.bg-repeat { + background-repeat: repeat; +} + +.bg-no-repeat { + bac...
Utility Request: background-repeat I believe the background-repeat utility is missing. Any specific reason why it is not included?
No specific reason, just haven't gotten around to discussing it yet. What values do you think are smart to include by default? I'm thinking at least `bg-repeat` and `bg-no-repeat` but not sure if the others are commonly used enough to justify including by default. I would like at least `bg-repeat-x` and `bg-repeat-y`. ...
2017-11-28T15:36:46Z
0.2
tailwindlabs/tailwindcss
77
tailwindlabs__tailwindcss-77
[ "55" ]
edb5c045f4cf81f5a8640ab9652cd67f21ab82b3
diff --git a/docs/tailwind.js b/docs/tailwind.js --- a/docs/tailwind.js +++ b/docs/tailwind.js @@ -1,4 +1,4 @@ -var config = require('../defaultConfig') +var config = require('../lib/index').defaultConfig() config.colors = { ...config.colors, diff --git a/src/index.js b/src/index.js --- a/src/index.js +++ b/src/i...
diff --git a/__tests__/applyAtRule.test.js b/__tests__/applyAtRule.test.js --- a/__tests__/applyAtRule.test.js +++ b/__tests__/applyAtRule.test.js @@ -1,14 +1,14 @@ import postcss from 'postcss' import plugin from '../src/lib/substituteClassApplyAtRules' -function run(input, opts) { +function run(input, opts = () =...
Triggering rebuild on config.js change Enjoying working with the release, good work! I'd like to propose triggering a rebuild when the config file (`tailwind-config.js`) is updated if a build tool is being used – ie. webpack. Basically in the same way as a new build is triggered when you update a css/sass/js fil...
I do not believe it's possible as the config is loaded into memory on the webpack side, and webpack doesn't watch it's own config files as it can't restart itself. How about an abstraction that watches for Laravel Mix (in my case) config changes or tailwind changes and restarts the watch command? This is a super annoyi...
2017-11-03T13:55:45Z
0.1
tailwindlabs/tailwindcss
82
tailwindlabs__tailwindcss-82
[ "75" ]
5c585f844ec1675b289c6f7f332cfc211dd8a1ff
diff --git a/src/generators/spacing.js b/src/generators/spacing.js --- a/src/generators/spacing.js +++ b/src/generators/spacing.js @@ -98,9 +98,15 @@ export default function ({ padding, margin, negativeMargin }) { definePadding(padding), defineMargin(margin), defineClasses({ + 'mt-auto': { + ...
diff --git a/__tests__/fixtures/tailwind-output.css b/__tests__/fixtures/tailwind-output.css --- a/__tests__/fixtures/tailwind-output.css +++ b/__tests__/fixtures/tailwind-output.css @@ -2982,10 +2982,18 @@ button, margin: 1px; } +.mt-auto { + margin-top: auto; +} + .mr-auto { margin-right: auto; } +.mb-a...
Add my-auto Hello. Adding "auto" suffix to margin vertical utilites can be usefull with flexbox: ```html <div class="h-half bg-grey-lighter flex"> <div class="ml-auto flex flex-col justify-end p-12 text-right"> <h2 class="my-auto text-5xl font-extrabold uppercase">Centered on rest block</h2> ...
This is super interesting and is the first time I've ever seen vertical margins of `auto` do anything at all 😄 I think what we're going to do is add this to the core utility set hardcoded like the horizontal auto variations for now, and then in the next breaking release (`0.2.0`) we'll move all of it out to the con...
2017-11-03T15:21:16Z
0.1
checkstyle/checkstyle
16,515
checkstyle__checkstyle-16515
[ "15769" ]
0f9d47e2ae3f0af2b1df2f98e44280db6b4d4931
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/BlockParentHandler.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/BlockParentHandler.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/BlockParentHandler.java +++ b/src/main/java/com/puppycra...
diff --git a/src/it/resources-noncompilable/com/google/checkstyle/test/chapter5naming/rule527localvariablenames/InputPatternVariableNameEnhancedInstanceofTestDefault.java b/src/it/resources-noncompilable/com/google/checkstyle/test/chapter5naming/rule527localvariablenames/InputPatternVariableNameEnhancedInstanceofTestDe...
google_checks.xml: remove xpath suppression and false-positive indentation violations for block codes I have read check documentation: https://checkstyle.org/checks/misc/indentation.html I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.html#Download_and_Run I have executed the cli and show...
I am on it
2025-03-10T03:15:29Z
10.23
checkstyle/checkstyle
16,605
checkstyle__checkstyle-16605
[ "9745" ]
88eb861f176bece7c70eb87f71a760e7bea7532a
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java +++ b/src/main/java/com/puppycrawl/tools/che...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheckTest.java --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheckTest.java +++ b/src/test/java/com/puppycra...
JavadocMethod: new property 'allowInlineReturn' to support for Javadoc return tag as inline I have downloaded the latest cli from: https://checkstyle.org/cmdline.html#Download_and_Run I have executed the cli and showed it below, as cli describes the problem better than 1,000 words **How it works Now:** ```bash ...
Similar to #10014 The pattern should be updated to something like ```java /** Compiled regexp to match Javadoc tags with no argument. */ private static final Pattern MATCH_JAVADOC_NOARG = CommonUtil.createPattern("^\\s*(?>\\*|\\/\\*\\*)?\\s*(\{?@return|@see)\\s+\\S"); ``` I would like to g...
2025-03-18T22:12:14Z
10.22
checkstyle/checkstyle
16,418
checkstyle__checkstyle-16418
[ "12817" ]
16687998321c29ad8519aa02bb48ecfb21595ccb
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/SwitchHandler.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/SwitchHandler.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/SwitchHandler.java +++ b/src/main/java/com/puppycrawl/tools/checks...
diff --git a/src/it/java/com/google/checkstyle/test/chapter4formatting/rule4841indentation/IndentationTest.java b/src/it/java/com/google/checkstyle/test/chapter4formatting/rule4841indentation/IndentationTest.java --- a/src/it/java/com/google/checkstyle/test/chapter4formatting/rule4841indentation/IndentationTest.java ++...
Incorrect Indentation errors for expression switches with google_checks.xml ```bash $ javac -fullversion javac full version "20-ea+35-2342" $ javac T.java $ wget https://raw.githubusercontent.com/checkstyle/checkstyle/d02e867225c3eaa43dc681c2827ce89799dee88f/src/main/resources/google_checks.xml $ cat T.java c...
maybe you are having problem with the compiler i have executed the file and it got implemented corrected.May be you are using the early release version.The file runs correctly with Java(TM) SE Runtime Environment (build 19.0.2+7-44) Java HotSpot(TM) 64-Bit Server VM (build 19.0.2+7-44, mixed mode, sharing). `class T...
2025-02-25T03:36:12Z
10.21
checkstyle/checkstyle
15,969
checkstyle__checkstyle-15969
[ "11374" ]
24eedce6a64145442db5b478c7a39ce0763dad8c
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheck.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheck.java +++ b/src/main/java/com/puppy...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheckTest.java --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheckTest.java +++ b/src/test/ja...
UnusedLocalVariable: False Positive when inner class has same field as variable I have read check documentation: https://checkstyle.sourceforge.io/config_coding.html#UnusedLocalVariable I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.html#Download_and_Run I have executed the cli and sho...
@Vishakhakumawat Fix has already been done, just pushing to remote is remaining, it is mentioned in issue description
2024-11-29T11:10:06Z
10.21
checkstyle/checkstyle
15,822
checkstyle__checkstyle-15822
[ "14424" ]
a4b0fc7b36dd1326a6c37d6b2b10070974967448
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheck.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheck.java +++ b...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheckTest.java --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheckTes...
HideUtilityClassConstructor - Add option to skip validation based on list of annotations I have read check documentation: https://checkstyle.org/checks/design/hideutilityclassconstructor.html I have downloaded the latest cli from: https://checkstyle.org/cmdline.html#Download_and_Run I have executed the cli and showed...
@nrmancuso , please review and approve if you agree with design. We can also start with simple implementation here (exact match), as we did in https://github.com/checkstyle/checkstyle/pull/14553, and extend check to handle imports as needed later. Hi, I would like to work on this
2024-10-26T20:18:58Z
10.19
checkstyle/checkstyle
15,686
checkstyle__checkstyle-15686
[ "15685" ]
70ef51748bb75f6cf636beea66b8ace18ba3a835
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/api/TokenTypes.java b/src/main/java/com/puppycrawl/tools/checkstyle/api/TokenTypes.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/api/TokenTypes.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/api/TokenTypes.java @@ -1215,7 +1215,7 @@ public ...
diff --git a/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule712paragraphs/InputIncorrectJavadocParagraph.java b/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule712paragraphs/InputIncorrectJavadocParagraph.java --- a/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule712para...
JavadocParagraph does not work when paragraphs have their corresponding closing tag I have read check documentation: https://checkstyle.org/checks/javadoc/javadocparagraph.html I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.html#Download_and_Run I have executed the cli and showed it belo...
2024-09-21T21:04:41Z
10.18
checkstyle/checkstyle
15,681
checkstyle__checkstyle-15681
[ "15263" ]
3d523d46c905d23131334073d882bfe490deac55
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheck.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheck.java +++ b/src/main/java/...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheckTest.java --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheckTest.java +++ b/sr...
UnnecessaryParenthesesCheck does not flag unnecessary parentheses in conditional expression detected at https://github.com/checkstyle/checkstyle/pull/15250#discussion_r1676837498 I have read check documentation: https://checkstyle.org/checks/coding/unnecessaryparentheses.html#UnnecessaryParentheses I have downloaded ...
Issue looks good to me. please add false negative label we usually place "bug" label after fix (as this label is for release notes) Is this still open and not assigned ? I think I have a solution for it but not sure if precedence order would affect this solution @MohanadKh03 , thanks a lot for help, you are alway...
2024-09-19T15:26:31Z
10.18
checkstyle/checkstyle
15,430
checkstyle__checkstyle-15430
[ "15047" ]
d325ed0fb7ede71fe1327bc2bfef362d51bdaf99
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheck.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheck.java +++ b/src/main/java/com/puppycrawl/too...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheckTest.java --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheckTest.java +++ b/src/test/java/com/pu...
Add Check Support for Java 21 Pattern Matching for Switch Syntax: NPathComplexity child of https://github.com/checkstyle/checkstyle/issues/14961 I have read check documentation:https://checkstyle.org/checks/metrics/npathcomplexity.html I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.htm...
Looks like a false negative, approving this one. https://checkstyle.org/checks/metrics/npathcomplexity.html#Description > Expressions Number of && and || operators in expression. No operators - 0 This check also counts expressions, so fixing `when` may cause other effects here. OP is updated, same result as before...
2024-08-03T13:16:45Z
10.17
checkstyle/checkstyle
15,334
checkstyle__checkstyle-15334
[ "15322" ]
6a3ab019020cf67973e4f3fdc8ace6d197eadddc
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/NeedBracesCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/NeedBracesCheck.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/NeedBracesCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/chec...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/NeedBracesCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/NeedBracesCheckTest.java --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/NeedBracesCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/che...
NeedBraces Check Should violate Switch Expressions with Arrow Syntax That Directly Yields a Value detected at https://github.com/checkstyle/checkstyle/pull/15321#discussion_r1684288238 I have read check documentation:https://checkstyle.org/checks/blocks/needbraces.html#NeedBraces I have downloaded the latest checksty...
2024-07-21T00:35:38Z
10.17
checkstyle/checkstyle
15,337
checkstyle__checkstyle-15337
[ "14975" ]
b10a1bf0d165a506a684aa8e1f84f485769c4986
diff --git a/src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionSealedShouldHavePermitsListTest.java b/src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionSealedShouldHavePermitsListTest.java new file mode 100644 --- /dev/null +++ b/src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegre...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/SealedShouldHavePermitsListCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/SealedShouldHavePermitsListCheckTest.java new file mode 100644 --- /dev/null +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/...
Add Check Support for Java 17 Sealed Classes: New Check SealedShouldHavePermitsList child of #14969 : > the sealed class may omit the permits clause and the Java compiler will infer the permitted subclasses from the declarations in the source file. (The subclasses may be auxiliary or nested classes.) A sealed cl...
Can you show what valid code should be (violations corrected by user). Also, what if we have another input file where sealed class A isn't a sub-class. Either it is the same subclasses as you showed now, or they are sibling classes in the same file. > ShouldPermitsSubClasses > subclasses are missing from permits...
2024-07-21T18:50:57Z
10.17
checkstyle/checkstyle
15,358
checkstyle__checkstyle-15358
[ "15058" ]
aeef199a44b3a54ac423830ade2c870f66f4bd0b
diff --git a/src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionUnusedCatchParameterShouldBeUnnamedTest.java b/src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionUnusedCatchParameterShouldBeUnnamedTest.java new file mode 100644 --- /dev/null +++ b/src/it/java/org/checkstyle/suppressionxpathf...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedCatchParameterShouldBeUnnamedCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedCatchParameterShouldBeUnnamedCheckTest.java new file mode 100644 --- /dev/null +++ b/src/test/java/com/puppycrawl/tools/checkstyl...
Add Check Support for Java 21 Unnamed Variables & Patterns Syntax: New Check UnusedCatchParameterShouldBeUnnamed child of #14942 violate the non-use of the catch parameters. They should be unnamed. --- **Config** ```XML $ cat config.xml <?xml version="1.0"?> <!DOCTYPE module PUBLIC "-//Checkstyl...
I am good with this. > `} catch (Exception e) { // violation` > `} catch (Exception _) {` Technically 2nd is "expected violation". 1st should be violation of old check? This is a new check and there are no actual violations yet. > Technically 2nd is "expected violation". 1st should be violation of old check? T...
2024-07-24T14:35:20Z
10.17
checkstyle/checkstyle
15,212
checkstyle__checkstyle-15212
[ "14805" ]
947002a3d66557d7e62a5aee81c7de449ce5f168
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/JavaAstVisitor.java b/src/main/java/com/puppycrawl/tools/checkstyle/JavaAstVisitor.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/JavaAstVisitor.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/JavaAstVisitor.java @@ -23,7 +23,6 @@ import jav...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/JavaAstVisitorTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/JavaAstVisitorTest.java --- a/src/test/java/com/puppycrawl/tools/checkstyle/JavaAstVisitorTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/JavaAstVisitorTest.java @@ -41,7 +41,...
Remove Support for String Template Syntax We always take a risk supporting preview features, and try to wait until second/third/final preview to add support for new syntax, to improve the chance that a given feature will become a part of the language permanently. Of course, this is also driven by user demand. Unfort...
2024-07-08T15:50:53Z
10.17
checkstyle/checkstyle
15,199
checkstyle__checkstyle-15199
[ "14985" ]
9a76f83d53021e01e2adb304a5d973ad4ec44117
diff --git a/src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionWhenShouldBeUsedTest.java b/src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionWhenShouldBeUsedTest.java new file mode 100644 --- /dev/null +++ b/src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionWhenShouldBeUsedT...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/WhenShouldBeUsedCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/WhenShouldBeUsedCheckTest.java new file mode 100644 --- /dev/null +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/WhenShouldBeUsedCheckT...
Add Check Support for Java 21 Pattern Matching for Switch Syntax: New Check WhenShouldBeUsed child of #14961: pattern matching for switch, allows more concise and readable code when dealing with various object types. This feature includes the `when` keyword to add conditions to case labels directly, improving reada...
Examples don't show but what if there is an else to the if or things besides the if statement? Are we going to print no violation? Yes, no violation. IMO if we have more than one condition to check in the case body then a series of `if elif else` will be more readable than using `when` However I don't have a strong op...
2024-07-04T23:09:44Z
10.17
checkstyle/checkstyle
15,127
checkstyle__checkstyle-15127
[ "15123" ]
0c13df61a826ad81668aab4c790a6342454de976
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/MissingSwitchDefaultCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/MissingSwitchDefaultCheck.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/MissingSwitchDefaultCheck.java +++ b/src/main/java/com/pu...
diff --git a/src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/missingswitchdefault/InputMissingSwitchDefaultCheckNullCaseLabel.java b/src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/missingswitchdefault/InputMissingSwitchDefaultCheckNullCaseLabel.java --- a/s...
MissingSwitchDefault : False positive when `case null` in switch labeled statement group Check documentation : https://checkstyle.org/checks/coding/missingswitchdefault.html#MissingSwitchDefault --- ``` PS D:\CS\test> javac src/Test.java PS D:\CS\test> cat src/Test.j...
2024-06-25T13:32:35Z
10.17
checkstyle/checkstyle
14,983
checkstyle__checkstyle-14983
[ "14981" ]
d5d90d1d5caa3febe095aad3d2f12a077b0b2148
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheck.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheck.java +++ b/src/main/java/com/puppycra...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java +++ b/src/test/java/...
False positive in FinalLocalVariable check on unnamed variables child #14942 I have read check documentation: https://checkstyle.org/checks/coding/finallocalvariable.html I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.html#Download_and_Run I have executed the cli and showed it below, as...
I am good to approve if we add a new property, `validateUnnamedVariables`. @rnveach please share your thoughts and approve if you agree. > validateUnnamedVariables [We have 6 "validate" properties. We have 46 "allow" properties. We have 22 "violate" properties. We have 48 "ignore" properties.](https://rveach.no-ip....
2024-06-13T14:25:44Z
10.17
checkstyle/checkstyle
14,882
checkstyle__checkstyle-14882
[ "14573" ]
36d991f54522e4ac4ac8142483590e0591b8a9a6
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheck.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyl...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheckTest.java --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheckTest.java +++ b/src/test/java/com/puppycrawl/too...
JavadocType: False negative for unknown tag with no description ([Documentation](https://checkstyle.org/checks/javadoc/javadoctype.html)) **config.xml** ```xml <?xml version="1.0"?> <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http://www.puppycrawl.com/dtds/configur...
Example showing that violation is produced as expected if the unknown tag is with the description. (same config is used) **Test.java** ```java /** * @val well well well, how the turntables */ class Test {} ``` **CLI:** `[ERROR] Test.java:2:4: Unknown tag 'val'. [JavadocType]` Resolution on https://githu...
2024-05-17T19:07:30Z
10.2
checkstyle/checkstyle
14,804
checkstyle__checkstyle-14804
[ "13086" ]
a7ca081725c9a152dadea835a75632bbe998d4c2
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheck.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheck.java +++ b/src/main/java/com/puppycrawl/tools/...
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheckTest.java --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheckTest.java +++ b/src/test/java/com/puppy...
InnerAssignmentCheck failed for one line code in Java 14 switch expression I have read check documentation: https://checkstyle.org/config_coding.html#InnerAssignment I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.html#Download_and_Run I have executed the cli and showed it below, as cli d...
@romani @nrmancuso there is an open PR for this but no activity since jan.idk if it is abandoned.so can i take this or should we wait @mahfouz72 you can pick it up, I closed the PR
2024-04-16T22:09:06Z
10.16
checkstyle/checkstyle
14,623
checkstyle__checkstyle-14623
[ "14620" ]
85987c3797a588ee495d07e4f4e146a8ae55fe04
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/RightCurlyCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/RightCurlyCheck.java --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/RightCurlyCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/chec...
diff --git a/src/it/java/com/google/checkstyle/test/chapter4formatting/rule412nonemptyblocks/RightCurlyTest.java b/src/it/java/com/google/checkstyle/test/chapter4formatting/rule412nonemptyblocks/RightCurlyTest.java --- a/src/it/java/com/google/checkstyle/test/chapter4formatting/rule412nonemptyblocks/RightCurlyTest.java...
LITERAL_CASE token support in RightCurlyCheck Currently [RightCurlyCheck](https://checkstyle.org/checks/blocks/rightcurly.html#RightCurly) accepts a less tokens than [LeftCurlyCheck](https://checkstyle.org/checks/blocks/leftcurly.html#LeftCurly) (19 tokens) This issue aims to add support for `LITERAL_CASE` token in Ri...
@mahfouz72 thanks for your report, issue is approved. Tests for this need to include: - Different inputs with all [RightCurlyOption](https://checkstyle.org/property_types.html#RightCurlyOption)s - switch statements, expressions - switch rules and block statements I am on it > switch statements, expressions ...
2024-03-07T16:03:45Z
10.15